Skip to content

chore: add Windows with VS 2022 and Node.JS 19.x to the CI matrix #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 19, 2022
Merged

chore: add Windows with VS 2022 and Node.JS 19.x to the CI matrix #1252

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1781d59
chore: add Windows and VS 2022 to the CI matrix
vmoroz Dec 16, 2022
90d7bda
apply windows-2022 only to node 18.x
vmoroz Dec 16, 2022
9afe67f
add Node 19.x to the test matrix for Windows
vmoroz Dec 16, 2022
e1285f6
add Node.JS 19.x to MacOS and Ubuntu runners
vmoroz Dec 16, 2022
2076cd1
Fix variable name
vmoroz Dec 16, 2022
a01886b
remove unused code to setup gcc 6.5
vmoroz Dec 17, 2022
75efc57
remove macos-latest + gcc from the matrix
vmoroz Dec 17, 2022
bbddeb8
try to fix the MacOS test matrix
vmoroz Dec 17, 2022
47ccdde
try an alternative way to exclude macos-gcc
vmoroz Dec 17, 2022
1a12f9a
use alternative syntax to exclude Node 14.x/window-2022
vmoroz Dec 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/ci-win.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@ jobs:
timeout-minutes: 30
strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
os:
- windows-2019
node-version: [14.x, 16.x, 18.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably ad 19.x here as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Let me try adding it,

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson , I have added Node.JS 19.x and updated the PR description.
Should I add Node.JS 19.x for non-Windows platforms in this PR too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vmoroz yes, we should have it for all platforms. We probably should have done it in Oct when 19.x was cut.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will do it then, while I am editing these files anyway. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson , I have added Node.JS 19x to the MacOS and Ubuntu runners. I also cleaned up the script a bit.

os: [ windows-2019 ]
include:
- node-version: 18.x
os: windows-2022
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
Expand Down