Skip to content

feat: Require semicolon to start chunk parameters. #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

feat: Require semicolon to start chunk parameters. #181

merged 1 commit into from
Aug 26, 2022

Conversation

ShogunPanda
Copy link
Contributor

Fixes #158.

@ShogunPanda ShogunPanda requested review from mcollina and ronag August 23, 2022 12:42
mcollina
mcollina approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda ShogunPanda merged commit abb4f43 into nodejs:main Aug 26, 2022
@ShogunPanda ShogunPanda deleted the strict-chunk-parameters branch August 26, 2022 09:41
@ShogunPanda ShogunPanda mentioned this pull request Oct 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@ronag ronag Awaiting requested review from ronag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrepancies in parsing http messages
2 participants
@ShogunPanda @mcollina