jenkins: use ccache with devtoolset on ppc64le #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Sep 26, 2019
|
It doesn't look like ubuntu was using ccache either for ppc64le |
Because devtoolset setup works by putting the devtoolset bin/ on the front of PATH the compiler is called directly instead of via the ccache wrappers. Change select-compiler.sh to explicitly use ccache, as it does for s390x.
ccache doesn't have wrappers for gcc-6,g++-4, etc., so call ccache explicitly.
BethGriggs
approved these changes
Sep 27, 2019
Closed
|
I reverted this, it broke node-test-commit-v8-linux: #1940 (comment) I'll come back to it when I have time. |
2 tasks
I found out via nodejs/node#31628 that it was by virtue of ccache symbolic links. |
richardlau
added a commit
to richardlau/node-1
that referenced
this pull request
Feb 7, 2020
Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: nodejs#31628 Refs: nodejs/build#1927 Refs: nodejs/build#1940 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
codebytere
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 17, 2020
Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: #31628 Refs: nodejs/build#1927 Refs: nodejs/build#1940 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
BethGriggs
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 26, 2020
Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: #31628 Refs: nodejs/build#1927 Refs: nodejs/build#1940 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
BethGriggs
pushed a commit
to nodejs/node
that referenced
this pull request
Mar 2, 2020
Refactor `tools/make-v8.sh` to minimise differences between the `ppc64le` and `s390x` paths to allow us to enable `ccache` on the `ppc64le` machines in the CI. PR-URL: #31628 Refs: nodejs/build#1927 Refs: nodejs/build#1940 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Sam Roberts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because devtoolset setup works by putting the devtoolset bin/ on the
front of PATH the compiler is called directly instead of via the ccache
wrappers.
Change select-compiler.sh to explicitly use ccache, as it does for s390x.