[Fusilli] Create FUSILLI_REQUIRE_OK macro #2556
Conversation
This odd [CI failure](https://github.com/nod-ai/shark-ai/actions/runs/18548883676/job/52872578004) might indicate a race on the compile cache (though I don't see how) or a sporadic device issue. It's hard to tell from the logs, and I haven't been able to reproduce this locally. This PR adds some logging so hopefully if this happens in CI again we can get a better picture of what's going on.
AaronStGeorge
force-pushed
the
require-ok-macro
branch
from
cb1141b to
28650db
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2556 +/- ##
=======================================
Coverage ? 77.31%
=======================================
Files ? 263
Lines ? 24839
Branches ? 0
=======================================
Hits ? 19204
Misses ? 5635
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AaronStGeorge
changed the title
| -DCMAKE_C_COMPILER=clang-20 | ||
| -DCMAKE_CXX_COMPILER=clang++-20 | ||
| -DCMAKE_BUILD_TYPE=Release | ||
| -DFUSILLI_ENABLE_LOGGING=ON |
There was a problem hiding this comment.
I'm not sure if we want to do this? If we have automated benchmark numbers someday the logging will slow things down. Though on a CI machine benchmarks would already be quite noisy.
There was a problem hiding this comment.
No harm I guess. Earlier we had logging on for debug builds only, but if we're trying to catch race issues, no harm in having better odds to catching it.
3 participants
This odd CI failure might indicate a race on the compile cache (though I don't see how) or a sporadic device issue. It's hard to tell from the logs, and I haven't been able to reproduce this locally. This PR adds some logging so hopefully if this happens in CI again we can get a better picture of what's going on.