Skip to content

Conversation

gkisalapl
Copy link
Contributor

@gkisalapl gkisalapl commented Sep 4, 2025

This PR make possible to perform windows build with FP16
enabled, uint16_t is used as FP16 storage only type

Self-evaluation:

  1. Build test: [X]Passed [ ]Failed [ ]Skipped
  2. Run test: [X]Passed [ ]Failed [ ]Skipped

p-debski2 and others added 17 commits August 25, 2025 16:43
Moved quantize functions from GGML to nntrainer

Signed-off-by: p-debski2 <[email protected]>
Added q8_0 row quantization, and multiple dequantization functions

Signed-off-by: p-debski2 <[email protected]>
Added includes for intrinsic functions

Signed-off-by: p-debski2 <[email protected]>
Moved nntr_ggml_impl to a separate directory and added a shared header with structure definitions

Signed-off-by: p-debski2 <[email protected]>
Added some util macros and functions to fix building on Linux

Signed-off-by: p-debski2 <[email protected]>
Moved more ggml functions and removed the includes from interface files so that they use only the nntr_ggml implementaion

Signed-off-by: p-debski2 <[email protected]>
Added more GGML type definitions for AVX operations

Signed-off-by: p-debski2 <[email protected]>
Removed ggml includes, renamed some functions, moved some declerations to common nntr_ggml_impl headers

Signed-off-by: p-debski2 <[email protected]>
Added a define guard to stop function redefinition

Signed-off-by: p-debski2 <[email protected]>
Added some comments for generating docs on helper GGML structures

Signed-off-by: p-debski2 <[email protected]>
Removed ggml from meson & tizen specification, leaving the submodule for now

Signed-off-by: p-debski2 <[email protected]>
Deleted ggml as a dependency from the project

Signed-off-by: p-debski2 <[email protected]>
This commit introduces mapping logic to the RMS Norm OpenCL kernel following kernel execution.
Additionally, this patch updates the unit tests for the OpenCL BLAS kernels.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
This commit adds helper functions for SVM allocation.
This patch also fixes issues where allocated memory is not destroyed.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
This commit introduces a fallback implementation for the fused unpack q4_0x8 and 16-bit transpose operation, which preprocesses q4_0x8 data.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
This commit adds AVX2 implementation of a fused unpack q4_0x8 and 16-bit transpose operation.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
This commit removes pre-allocated SVM for transposed data.

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Donghyeon Jeong <[email protected]>
@gkisalapl gkisalapl changed the title Fp16 windows Fp16 windows (depends on #3429) Sep 4, 2025
This PR make possible to perform windows build with FP16
enabled, uint16_t is used as FP16 storage only type

**Self-evaluation:**
1. Build test: [X]Passed [ ]Failed [ ]Skipped
2. Run test:   [X]Passed [ ]Failed [ ]Skipped

Signed-off-by: Grzegorz Kisala <[email protected]>
@gkisalapl
Copy link
Contributor Author

PR replaced by #3468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants