[ggml] Imported frequently used ggml functions into nntrainer #3429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-debski2
force-pushed
the
work/ggml-integration
branch
2 times, most recently
from
7807ab8 to
a92ffb3
Compare
Moved quantize functions from GGML to nntrainer Signed-off-by: p-debski2 <[email protected]>
Added q8_0 row quantization, and multiple dequantization functions Signed-off-by: p-debski2 <[email protected]>
Added includes for intrinsic functions Signed-off-by: p-debski2 <[email protected]>
Moved nntr_ggml_impl to a separate directory and added a shared header with structure definitions Signed-off-by: p-debski2 <[email protected]>
Added some util macros and functions to fix building on Linux Signed-off-by: p-debski2 <[email protected]>
Moved more ggml functions and removed the includes from interface files so that they use only the nntr_ggml implementaion Signed-off-by: p-debski2 <[email protected]>
Added more GGML type definitions for AVX operations Signed-off-by: p-debski2 <[email protected]>
Removed ggml includes, renamed some functions, moved some declerations to common nntr_ggml_impl headers Signed-off-by: p-debski2 <[email protected]>
Added a define guard to stop function redefinition Signed-off-by: p-debski2 <[email protected]>
p-debski2
force-pushed
the
work/ggml-integration
branch
from
a92ffb3 to
79ca32f
Compare
Added some comments for generating docs on helper GGML structures Signed-off-by: p-debski2 <[email protected]>
p-debski2
force-pushed
the
work/ggml-integration
branch
from
07adfd2 to
d54ccb7
Compare
p-debski2
requested review from
myungjoo,
jijoongmoon,
again4you,
jaeyun-jung,
leemgs,
wooksong,
gichan-jang,
anyj0527,
lhs8928,
songgot,
jihochu,
DonghakPark,
SeoHyungjun and
baek2sm
as code owners
p-debski2
requested review from
skykongkong8,
djeong20,
EunjuYang,
dkjung and
haehun
as code owners
|
I think it is OK to include the code to remove the ggml submodule. |
Removed ggml from meson & tizen specification, leaving the submodule for now Signed-off-by: p-debski2 <[email protected]>
Deleted ggml as a dependency from the project Signed-off-by: p-debski2 <[email protected]>
p-debski2
force-pushed
the
work/ggml-integration
branch
from
ad3b72a to
b95b19b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nntr_ggml_impldirectory and used those instead of the actual GGML in theggml_interfacefunctionsggml_interfaceSigned-off-by: p-debski2 [email protected]