Add support for SockAddr::Link when receiving packets
#1344
Conversation
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Looks pretty good. Let's just try adding fuchsia support.
CHANGELOG.md
Outdated
| - Added `mremap` (#[1306](https://github.com/nix-rust/nix/pull/1306)) | ||
| ### Changed | ||
| ### Fixed | ||
| - Fixed calling `recvfrom` on an `AddrFamily::Packet` socket (#[1344](https://github.com/nix-rust/nix/pull/1344)) |
| }; | ||
| Ok(SockAddr::Unix(UnixAddr(sun, pathlen))) | ||
| } | ||
| #[cfg(any(target_os = "android", target_os = "linux"))] |
There was a problem hiding this comment.
Err, wait on that. Fuchsia support hasn't merged yet.
There was a problem hiding this comment.
While the Fuchsia's libc (being a based on a Musl fork) has the defines and structures, I don't think it actually supports raw packet sockets (based on a cursory glance of it's own API) and that they're really just relics of the fork. But given that it's in their libc might be enough of a reason to support it.
|
I'm afraid you'll need to rebase to fix the CHANGELOG. |
|
@asomers is there anything left I can do to get this over the finish line? |
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
Sorry I've been ignoring this. I don't have much time to work on Nix anymore. But the PR looks good now.
bors r+
2 participants
fixes #1343