Add a passwd field to Group #1338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asomers
reviewed
Nov 28, 2020
Member
asomers
left a comment
asomers
left a comment
There was a problem hiding this comment.
What systems actually use the group password? I for one have never seen it actually used.
Contributor
Author
|
I haven't actually seen it used either, but I'm working on a backend to nscd and glibc seems to expect a group password as part of the response. Given that passwd is mentioned in the man page, is there a reason to not include it here? |
Contributor
Author
|
@asomers given this any more thought? |
Member
|
Yes, I think it seems reasonable. But could you add a CHANGELOG entry and rebase? |
blinsay
force-pushed
the
benl/group-passwords
branch
from
63da96e to
1e33e77
Compare
blinsay
force-pushed
the
benl/group-passwords
branch
from
1e33e77 to
8dc757b
Compare
Contributor
Author
|
Done! Sorry for the delay. |
Contributor
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
passwdfield to unistd::Group. Thegr_passwdfield exists onlibc::groupand wasn't exposed.I didn't see tests for
from(libc:group)for eitherUserorPassword. Let me know if there are other tests I should add!