Skip to content

Conversation

@wrvsrx
Copy link

@wrvsrx wrvsrx commented Oct 16, 2025

This PR allows specify plasma workspace in kde module.


@stylix-automation stylix-automation bot added topic: home-manager Home Manager target topic: modules /modules/ subsystem labels Oct 16, 2025
@wrvsrx wrvsrx force-pushed the allow-specify-plasma-workspace branch from 128f839 to f18914e Compare October 16, 2025 08:16
@wrvsrx wrvsrx force-pushed the allow-specify-plasma-workspace branch from f18914e to 264a097 Compare October 16, 2025 08:52
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC: @lordkekz, @rkuklik


@lordkekz and @rkuklik, our KDE module would not have been possible without your hard work. Do you mind adding yourself as a KDE module maintainer? The new /.github/workflows/request-reviewers.yml action will automatically notify you about PRs touching the /modules/kde/ directory. The following documentation extract explains how to add yourself as a module maintainer:

stylix/doc/src/modules.md

Lines 228 to 264 in 8d00829

### Maintainers
New modules must have at least one maintainer.
If you are not already listed in the Nixpkgs `/maintainers/maintainer-list.nix`
maintainer list, add yourself to `/stylix/maintainers.nix`.
Add yourself as a maintainer in one of the following ways, depending on the
number of maintainers:
- ```nix
{ lib, ... }:
{
maintainers = [ lib.maintainers.danth ];
}
```
- ```nix
{ lib, ... }:
{
maintainers = with lib.maintainers; [
awwpotato
danth
naho
];
}
```
The main responsibility of module maintainers is to update and fix their
modules.
> [!NOTE]
> If this is the first time you're adding yourself as a maintainer in Stylix,
> the `/generated/all-maintainers.nix` file will need to be updated by running
> `nix run .#all-maintainers`
> ([pre-commit](./development_environment.md#pre-commit) will also automatically
> regenerate it).

@wrvsrx wrvsrx force-pushed the allow-specify-plasma-workspace branch from 264a097 to d95272e Compare October 17, 2025 11:21
@wrvsrx wrvsrx requested a review from trueNAHO October 18, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: home-manager Home Manager target topic: modules /modules/ subsystem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants