-
-
Notifications
You must be signed in to change notification settings - Fork 271
Allow specify plasma workspace #1943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Allow specify plasma workspace #1943
Conversation
128f839 to
f18914e
Compare
f18914e to
264a097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lordkekz and @rkuklik, our KDE module would not have been possible without your hard work. Do you mind adding yourself as a KDE module maintainer? The new /.github/workflows/request-reviewers.yml action will automatically notify you about PRs touching the /modules/kde/ directory. The following documentation extract explains how to add yourself as a module maintainer:
Lines 228 to 264 in 8d00829
| ### Maintainers | |
| New modules must have at least one maintainer. | |
| If you are not already listed in the Nixpkgs `/maintainers/maintainer-list.nix` | |
| maintainer list, add yourself to `/stylix/maintainers.nix`. | |
| Add yourself as a maintainer in one of the following ways, depending on the | |
| number of maintainers: | |
| - ```nix | |
| { lib, ... }: | |
| { | |
| maintainers = [ lib.maintainers.danth ]; | |
| } | |
| ``` | |
| - ```nix | |
| { lib, ... }: | |
| { | |
| maintainers = with lib.maintainers; [ | |
| awwpotato | |
| danth | |
| naho | |
| ]; | |
| } | |
| ``` | |
| The main responsibility of module maintainers is to update and fix their | |
| modules. | |
| > [!NOTE] | |
| > If this is the first time you're adding yourself as a maintainer in Stylix, | |
| > the `/generated/all-maintainers.nix` file will need to be updated by running | |
| > `nix run .#all-maintainers` | |
| > ([pre-commit](./development_environment.md#pre-commit) will also automatically | |
| > regenerate it). |
264a097 to
d95272e
Compare
This PR allows specify plasma workspace in kde module.