-
-
Notifications
You must be signed in to change notification settings - Fork 50
flake: update nixpkgs input, nixVersions.nix_2_28 -> nixVersions.nix_2_30 #709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Huh, UBSAN barfs on: |
|
Bumping boost seems to help here, but some tests start failing for unclear reasons... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! It would be great if this patch could be merged, but the CI failures need to be fixed first.
|
The failures are really weird. When I run lit with a bunch of processes the |
|
Ok, so the boost thing is broken because it really does have an uninitialized variable: boostorg/asio@30b5974 |
…2_30 Nix 2.30 has significanltly improved memory usage and eval performance, which would be nice to have in nixd. Unpinning boost182 is necessary because: 1. Now nix from nixpkgs propagates its boost build input. 2. Linking 2 different versions of boost into the same executable is rather risky wrt to ABI breaks.
This is the new componenentized packaging abstraction for newer versions of nix. This doesn't bring in any of the cli components, unlike the old approach.
|
FML! This is a boost bug indeed. @inclyc, the CI is now fixed. Here's what was causing those failures:
This caused either a) random failures b) UBSAN to spew errors (#709 (comment)) |
|
LGTM, thank you! |
Nix 2.30 has significanltly improved memory usage and eval performance,
which would be nice to have in nixd.
Unpinning boost182 is necessary because:
wrt to ABI breaks.