nixd: enable completion and hover in config sets #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not-my-profile
force-pushed
the
complete-config
branch
from
3db95ac to
bc1ebc9
Compare
inclyc
reviewed
Apr 27, 2025
not-my-profile
force-pushed
the
complete-config
branch
2 times, most recently
from
1440b5f to
2fc14e8
Compare
not-my-profile
changed the title
not-my-profile
force-pushed
the
complete-config
branch
from
2fc14e8 to
93d37be
Compare
inclyc
reviewed
Apr 27, 2025
not-my-profile
force-pushed
the
complete-config
branch
from
93d37be to
ce5d40b
Compare
not-my-profile
changed the title
not-my-profile
force-pushed
the
complete-config
branch
from
ce5d40b to
adc3862
Compare
inclyc
approved these changes
Apr 30, 2025
In NixOS modules options can be defined at the top-level, e.g:
{ foo = true; }
or inside of `config`, e.g:
{ config = { foo = true; }; }
Autocompletion and hover information before only worked for the former
because the option resolving code had no special handling for `config`.
Fixes nix-community#566.
not-my-profile
force-pushed
the
complete-config
branch
from
adc3862 to
9a46044
Compare
inclyc
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In NixOS modules options can be defined at the top-level, e.g:
or inside of
config, e.g:Autocompletion and hover information before only worked for the former because the option resolving code had no special handling for
config.Fixes #566.