Skip to content

Conversation

@inclyc
Copy link
Member

@inclyc inclyc commented Nov 15, 2024

No description provided.

@inclyc inclyc added the NFC No functional change label Nov 15, 2024
@inclyc inclyc merged commit 0f3c0c7 into main Nov 15, 2024
19 checks passed
@inclyc inclyc deleted the ci-pr branch November 15, 2024 04:43
name: Meson

on:
[push, pull_request]
Copy link
Member

@Mic92 Mic92 Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is what you want. Because now pull requests from third-party are build in the pull request.

I think what you want is:

on:
  pull_request:
  push:
    branches:
      - main

The pull_request target also will build the merge rather pushed branch, which is more correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NFC No functional change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants