nixd: replace nixpkgs-fmt with nixfmt #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastienhurtel
requested review from
573,
Ruixi-rebirth and
inclyc
as code owners
Contributor
Author
|
Wrong repo, sorry for the noise! |
Member
|
Nice patch! Why cannot we just accept it? |
inclyc
reviewed
Aug 4, 2024
Member
There was a problem hiding this comment.
Currently I see nixpkgs-fmt is archived, so I think generally it is a good step to set our default to nixfmt-rfc-style.
Regression tests depending on nixpkgs-fmt might be a funny fake-dependency that could be resolved. See issue #570
Contributor
Author
|
Hello, I assume your talking about nixpkgs-fmt? |
inclyc
reviewed
Aug 7, 2024
inclyc
force-pushed
the
shu/replace-nixpkgs-fmt-with-nixfmt
branch
from
22c428d to
fb9b136
Compare
Member
|
@Aleksanaa why treefmt is still failing? |
Member
|
Works now. |
inclyc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to replace nixpkgs-fmt with nixfmt.