Skip to content

sherlock: use X-Restart-Triggers instead of onChange #7698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025

Conversation

74k1
Copy link
Contributor

@74k1 74k1 commented Aug 19, 2025

As suggested in #7678 (comment)

As rycee already mentioned, this will make sd-switch handle the restart.

I also added myself as a maintainer to this module. If this is unwanted, please let me know.

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@home-manager-ci home-manager-ci bot requested a review from khaneliman August 19, 2025 16:27
@74k1 74k1 mentioned this pull request Aug 19, 2025
9 tasks
@74k1
Copy link
Contributor Author

74k1 commented Aug 19, 2025

I suppose the tests failed because I'm not in all-maintainers.nix yet. Is there anything I can do about this?

@74k1 74k1 force-pushed the fix/sherlock-daemon branch from fc21534 to 1f21cab Compare August 19, 2025 17:15
@74k1 74k1 force-pushed the fix/sherlock-daemon branch from 1f21cab to 7aef838 Compare August 19, 2025 17:19
@khaneliman
Copy link
Collaborator

Looks like it needs a nix fmt

@74k1 74k1 force-pushed the fix/sherlock-daemon branch from 7aef838 to 6bb80fc Compare August 19, 2025 17:22
@khaneliman khaneliman merged commit dd026d8 into nix-community:master Aug 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants