Skip to content

satty: init module #7694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

Conversation

gauthsvenkat
Copy link
Contributor

@gauthsvenkat gauthsvenkat commented Aug 18, 2025

Description

Added a new module, programs.satty: a screenshot annotation tool (homepage).

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.

  • Code tested through nix run .#tests -- test-all or
    nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.
    • Generate a news entry. See News
    • Basic tests added. See Tests
  • If this PR adds an exciting new feature or contains a breaking change.

    • Generate a news entry. See News

@gauthsvenkat
Copy link
Contributor Author

Not sure why CI is failing. Seems like I did everything correct.

@gauthsvenkat
Copy link
Contributor Author

test-all-no-big-ifd is failing but seems unrelated to my changes.

@khaneliman
Copy link
Collaborator

error: attribute 'gauthsvenkat' missing
at /nix/store/z4mfi70l9yigv1f257hp2wxl886894nj-source/modules/programs/satty.nix:13:24:
12| {
13| meta.maintainers = [ lib.maintainers.gauthsvenkat ];
| ^
14|

You'd be in lib.hm.maintainers. Can you also squash the tests/news entry commits into the new module commit.

Add satty, a wlroots based screenshot annotation tool, to the programs
module.
@gauthsvenkat
Copy link
Contributor Author

gauthsvenkat commented Aug 19, 2025

You'd be in lib.hm.maintainers. Can you also squash the tests/news entry commits into the new module commit.

Thanks, that fixed it.

Squashed the commits too.

@khaneliman khaneliman merged commit 8af2e06 into nix-community:master Aug 19, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants