nix-gc: rename frequency to dates #7670
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguirre-matteo
force-pushed
the
rename-nix-gc
branch
from
600719f to
e3ab7a8
Compare
khaneliman
reviewed
Aug 13, 2025
aguirre-matteo
force-pushed
the
rename-nix-gc
branch
3 times, most recently
from
1f9f513 to
75d8380
Compare
aguirre-matteo
force-pushed
the
rename-nix-gc
branch
from
75d8380 to
5efbb32
Compare
|
As far I can see, the old module used |
ambroisie
reviewed
Aug 15, 2025
Comment on lines
+37
to
+38
| type = with types; either singleLineStr (listOf str); | ||
| apply = lib.toList; |
There was a problem hiding this comment.
Maybe:
Suggested change
| type = with types; either singleLineStr (listOf str); | |
| apply = lib.toList; | |
| type = with types; coercedTo str lib.toList (listOf str); |
There was a problem hiding this comment.
I did the above because the NixOS module does it that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames the
nix.gc.frequencyoption tonix.gc.datesto match upstream NixOS' module. Closes #5106.Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See
example.
Commit messages are formatted like
See CONTRIBUTING for more information and
recent commit messages for examples.
If this PR adds a new module
example.
News
Tests
If this PR adds an exciting new feature or contains a breaking change.
News