Skip to content

fix: add unenv aliases for process/ and string_decoder/ #3273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

fix: add unenv aliases for process/ and string_decoder/ #3273

merged 2 commits into from
Apr 3, 2025

Conversation

@felixgabler
Copy link
Contributor

@felixgabler felixgabler commented Apr 2, 2025

#3271

🔗 Linked issue

#3271

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

As discussed, resolves #3271

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@felixgabler felixgabler requested a review from pi0 as a code owner April 2, 2025 12:34
@pi0 pi0 changed the title fix: add aliases for readable-stream process/ and string_decoder/ fix: add unenv aliases for process/ and string_decoder/ Apr 2, 2025
pi0
pi0 approved these changes Apr 2, 2025
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thnx!

@pi0 pi0 merged commit 0b5938d into nitrojs:v3 Apr 3, 2025
5 of 7 checks passed
pi0 pushed a commit that referenced this pull request Apr 7, 2025
@felixgabler @pi0
fix: add unenv aliases for process/ and string_decoder/ (#3273)
ac1af7f
This was referenced Apr 27, 2025
Merged
Closed
@pi0 pi0 mentioned this pull request Jun 11, 2025
Merged
@pi0 pi0 mentioned this pull request Jun 25, 2025
Merged
This was referenced Jul 12, 2025
Merged
Merged
Merged
@pi0 pi0 mentioned this pull request Sep 2, 2025
Merged
@Hebilicious Hebilicious mentioned this pull request Sep 14, 2025
Draft
8 tasks
@pi0 pi0 mentioned this pull request Sep 26, 2025
Merged
@pi0 pi0 mentioned this pull request Oct 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build fails with ENOTDIR error for _unenv/workerd/process.mjs when using cloudflare-pages preset

2 participants

@felixgabler @pi0