Skip to content

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 4, 2025

This is a potential fix to #3475 and #3508. To test:

git clone https://github.com/nipreps/fmriprep.git fmriprep-3516
git -C fmriprep-3516 fetch origin refs/pull/3516/head
git -C fmriprep-3516 checkout FETCH_HEAD
fmriprep-docker [NORMAL ARGS] --patch fmriprep=$PWD/fmriprep-3516/fmriprep

@claraElk @HippocampusGirl Could you verify that this does not re-introduce the problems we were trying to fix in #3453?

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.64%. Comparing base (cfe7a06) to head (bc5c33f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3516   +/-   ##
=======================================
  Coverage   73.64%   73.64%           
=======================================
  Files          60       60           
  Lines        4759     4759           
  Branches      616      616           
=======================================
  Hits         3505     3505           
  Misses       1111     1111           
  Partials      143      143           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HippocampusGirl
Copy link
Contributor

Thanks for the heads-up! @claraElk and I are happy to have a look, but we likely need a week or two to re-run the analysis and get results

@effigies
Copy link
Member Author

effigies commented Sep 4, 2025

Sounds good. Will check in in two weeks.

HippocampusGirl added a commit to HALFpipe/HALFpipe that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants