Skip to content

Conversation

mgxd
Copy link
Collaborator

@mgxd mgxd commented Sep 1, 2022

Fixes #2839

I'm considering whether its cleaner to add sbrefs as a parameter to the workflow (function signature changing, so in a future minor bump) since we already have a data collection step

subject_data = collect_data(
config.execution.layout,
subject_id,
task=config.execution.task_id,
echo=config.execution.echo_idx,
bids_filters=config.execution.bids_filters)[0]

@mgxd mgxd changed the base branch from master to maint/22.0.x September 1, 2022 14:05
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (maint/22.0.x@e963b77). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             maint/22.0.x    #2843   +/-   ##
===============================================
  Coverage                ?   45.38%           
===============================================
  Files                   ?       45           
  Lines                   ?     3426           
  Branches                ?        0           
===============================================
  Hits                    ?     1555           
  Misses                  ?     1871           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mgxd
Copy link
Collaborator Author

mgxd commented Sep 2, 2022

Tested locally and working as expected

@mgxd mgxd merged commit 07f30e2 into nipreps:maint/22.0.x Sep 2, 2022
@mgxd mgxd deleted the fix/sbref-filtering branch September 2, 2022 19:54
mgxd added a commit that referenced this pull request Sep 6, 2022
FIX: Filter sbrefs by BIDS filters if available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--bids-filter-file doesn't appear to recognize certain exclusion criteria
3 participants