Skip to content

fix: make sure nimble bin dir exists before trying to install DLLs there #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ringabout merged 2 commits into from
Jul 10, 2025
Merged

fix: make sure nimble bin dir exists before trying to install DLLs there #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66c5acb
fix: make sure nimble bin dir exists before trying to install DLLs there
SpotlightKid Jul 10, 2025
cd173c7
refactor: use os.fileNewer instead of comparing file mod times manually
SpotlightKid Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/choosenim.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Copyright (C) Dominik Picheta. All rights reserved.
# BSD-3-Clause License. Look at license.txt for more info.
import os, strutils, algorithm
import std/[os, strutils, algorithm]

import nimblepkg/[cli, version]
import nimblepkg/common as nimbleCommon
Expand Down Expand Up @@ -94,11 +94,11 @@ proc chooseVersion(version: string, params: CliParams) =
removeDir(tempDir)
createDir(tempDir)
extract(path, tempDir)
createDir(binDir)
for kind, path in walkDir(tempDir, relative = true):
if kind == pcFile:
try:
if not fileExists(binDir / path) or
getLastModificationTime(binDir / path) < getLastModificationTime(tempDir / path):
if not fileExists(binDir / path) or fileNewer(tempDir / path, binDir / path):
moveFile(tempDir / path, binDir / path)
display("Info:", "Copied '$1' to '$2'" % [path, binDir], priority = HighPriority)
except:
Expand Down