Skip to content

Configure Stylelint with GOV.UK Frontend property order #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 15, 2025
Merged

Configure Stylelint with GOV.UK Frontend property order #1589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
15508e9
Remove Stylelint rules duplicated in `stylelint-config-gds/scss`
colinrotherham Sep 15, 2025
43aa47d
Remove unnecessary Stylelint rules and comments
colinrotherham Sep 15, 2025
5ead646
Add new Stylelint comments
colinrotherham Sep 15, 2025
0ed07ef
Consolidate Stylelint overrides
colinrotherham Sep 15, 2025
77d80a1
Configure Stylelint with GOV.UK Frontend property order
colinrotherham Sep 15, 2025
54d7d09
Configure Stylelint with grouping
colinrotherham Sep 15, 2025
c063bce
Configure Stylelint for flex layout
colinrotherham Sep 15, 2025
453e217
Configure Stylelint for column layout
colinrotherham Sep 15, 2025
a02806c
Configure Stylelint for grid layout
colinrotherham Sep 15, 2025
8795ded
Configure Stylelint for masks
colinrotherham Sep 15, 2025
4215a14
Add Stylelint order missing properties
colinrotherham Sep 15, 2025
2627d89
Run `lint:css:fix`
colinrotherham Sep 15, 2025
b1c29eb
Use prefered stylelint.config.mjs filename
colinrotherham Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
114 changes: 0 additions & 114 deletions .stylelintrc.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions docs/contributing/linting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ We use the following rules when linting files:
Bad:

```scss
.selector {border: 0; padding: 0;}
.selector { padding: 0; border: 0;}
```

Good:

```scss
.selector {
border: 0;
padding: 0;
border: 0;
}
```

Expand Down
12 changes: 6 additions & 6 deletions packages/nhsuk-frontend/src/nhsuk/components/action-link/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@

.nhsuk-action-link {
display: inline-block; // [1]
padding-left: nhsuk-px-to-rem($_small-icon-size + $_small-icon-spacing); // [2]
position: relative; // [3]
padding-left: nhsuk-px-to-rem($_small-icon-size + $_small-icon-spacing); // [2]
text-decoration: none; // [4]

&:not(:focus):hover {
Expand All @@ -42,20 +42,20 @@
@include nhsuk-responsive-margin(6, "bottom");

@include nhsuk-media-query($from: tablet) {
line-height: nhsuk-line-height($_large-icon-size, $font-size: 22);
padding-left: nhsuk-px-to-rem($_large-icon-size + $_large-icon-spacing); // [2]
line-height: nhsuk-line-height($_large-icon-size, $font-size: 22);
}

.nhsuk-icon {
position: absolute;
left: nhsuk-px-to-rem(-$_small-icon-spacing);
// stylelint-disable-next-line declaration-no-important
fill: nhsuk-colour("green") !important;
left: nhsuk-px-to-rem(-$_small-icon-spacing);
position: absolute;

@include nhsuk-media-query($from: tablet) {
height: nhsuk-px-to-rem($_large-icon-size);
width: nhsuk-px-to-rem($_large-icon-size);
left: nhsuk-px-to-rem(-$_large-icon-spacing);
width: nhsuk-px-to-rem($_large-icon-size);
height: nhsuk-px-to-rem($_large-icon-size);
}
}

Expand Down
21 changes: 14 additions & 7 deletions packages/nhsuk-frontend/src/nhsuk/components/back-link/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,18 @@
$_font-size: 16;

.nhsuk-back-link {
background: none;
border: 0;
cursor: pointer;
display: inline-block;

position: relative;

padding: 0;
padding-left: nhsuk-em($_font-size, $nhsuk-base-font-size);
position: relative;

border: 0;

background: none;

cursor: pointer;

@include nhsuk-font($_font-size);
@include nhsuk-link-style-default;
Expand All @@ -29,12 +34,14 @@
@include nhsuk-print-hide; // [2]

&::before {
bottom: 0;
content: "";
left: 0;
margin: auto;

position: absolute;
top: 0;
bottom: 0;
left: 0;

margin: auto;

@include nhsuk-shape-chevron(left, $colour: currentcolor, $font-size: 19);
}
Expand Down
14 changes: 8 additions & 6 deletions packages/nhsuk-frontend/src/nhsuk/components/breadcrumb/_index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
}

.nhsuk-breadcrumb__list {
list-style: none;
margin: 0;
padding: 0;
list-style: none;

@include nhsuk-clearfix;
@include nhsuk-font($_font-size);
Expand All @@ -47,19 +47,21 @@
}

.nhsuk-breadcrumb__list-item {
float: left;
position: relative;
margin-bottom: 0;
margin-left: nhsuk-em(nhsuk-spacing(3), $_font-size); // [3]
padding-left: nhsuk-em(nhsuk-spacing(3), $_font-size) + $_chevron-size; // [3]
position: relative;
float: left;

&::before {
bottom: 0;
content: "";
left: 0;
margin: auto;

position: absolute;
top: 0;
bottom: 0;
left: 0;

margin: auto;

@include nhsuk-shape-chevron(right, $_chevron-colour);
}
Expand Down
Loading