Skip to content

Conversation

colinrotherham
Copy link
Contributor

Description

This PR adds the password input component from GOV.UK Frontend

Mostly to demonstrate afterInput in #1561 buts highlights our lack of inline button styles

Password input with button height mismastch

Checklist

Copy link

gitguardian bot commented Sep 12, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
20781244 Triggered Generic Password 722bdd4 packages/nhsuk-frontend/src/nhsuk/components/password-input/macro-options.mjs View secret
20781245 Triggered Generic Password 722bdd4 packages/nhsuk-frontend/src/nhsuk/components/password-input/macro-options.mjs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

sonarqubecloud bot commented Sep 12, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
49.1% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant