Skip to content

Conversation

@nathanweeks
Copy link
Member

Fixes issue #124 , checking if for a non-null/"file" scheme before attempting to resolve symlinks to avoid breaking cloud storage paths as supported in PR #122.

I manually tested (using --profile singularity) the case where a fastq_dir specified in the sample sheet is a symlink---not sure if it's worth adding an explicit test? Also, note that I'm only a "groovy novice", and suggestions containing a more robust or conventional implementation would be appreciated.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/spatialvi branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Collaborator

@fasterius fasterius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

@fasterius fasterius merged commit 0074225 into nf-core:dev Nov 24, 2025
13 checks passed
@nathanweeks nathanweeks deleted the issue-124 branch November 24, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants