Skip to content

Conversation

Marta2906
Copy link

@Marta2906 Marta2906 commented Nov 11, 2024


name: New Config
about: A new cluster config

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@pontus
Copy link
Contributor

pontus commented Nov 11, 2024

Looks good, but I clicked a bit fast. The other steps in the list (docs, nfcore_custom.config) and so on seem to be missing still?

@jfy133 jfy133 self-requested a review November 11, 2024 16:05
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfy133
Copy link
Member

jfy133 commented Nov 11, 2024

@nf-core-bot fix linting

@Joon-Klaps
Copy link
Contributor

hi @Marta2906,
do you think you will be able to work on this during the upcoming hackathon or do you need help getting this PR over the finish line? 😊

@Marta2906
Copy link
Author

Hi @Joon-Klaps. My apologies for not finishing this earlier, I’ve been overwhelmed with too many other things. I’ll complete it in the next few days, and if I need any help, I’ll let you know. Thank you very much, and sorry for the inconvenience! :)

@Joon-Klaps Joon-Klaps moved this from In Progress to Todo in 2025 spring cleaning - the rest Mar 14, 2025
@Joon-Klaps Joon-Klaps moved this from Todo to In Progress in 2025 spring cleaning - the rest Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants