-
Notifications
You must be signed in to change notification settings - Fork 109
fix: constrain height of video preview #8118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: silver <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
mejo-
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me. I guess limiting the height of the container means that videos (e.g. portrait format videos) will be resized to fit into this container no matter what? In any case I think 400px is a reasonable maximum height for a container of an embedded object.
max-nextcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Shall we backport this?
|
/backport to stable32 please |
|
/backport to stable31 please |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/8118/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4c277995
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8118/stable31Error: Failed to check for changes with origin/stable31: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
Merging and creating backport PRs - we can discuss the backports there in case they are controversial. |
📝 Summary
The height of embedded videos is too big. This PR adds styling constraints to the video-wrapper.
🖼️ Screenshots
🏚️ Before | 🏡 After


|
B | A
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)