Skip to content

Conversation

@silverkszlo
Copy link
Collaborator

📝 Summary

The height of embedded videos is too big. This PR adds styling constraints to the video-wrapper.

🖼️ Screenshots

🏚️ Before | 🏡 After
Screenshot from 2025-12-22 15-31-47
|
Screenshot from 2025-12-22 15-32-15

B | A

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. I guess limiting the height of the container means that videos (e.g. portrait format videos) will be resized to fit into this container no matter what? In any case I think 400px is a reasonable maximum height for a container of an embedded object.

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Shall we backport this?

@max-nextcloud
Copy link
Collaborator

/backport to stable32 please

@max-nextcloud
Copy link
Collaborator

/backport to stable31 please

@max-nextcloud max-nextcloud merged commit 550df2e into main Dec 27, 2025
64 checks passed
@max-nextcloud max-nextcloud deleted the fix/embedded_videos_height branch December 27, 2025 11:42
@backportbot
Copy link

backportbot bot commented Dec 27, 2025

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/8118/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 4c277995

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/8118/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@max-nextcloud
Copy link
Collaborator

Merging and creating backport PRs - we can discuss the backports there in case they are controversial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Height of embedded videos added to page is too big

4 participants