fix(sharing): Use insertIfNotExists to insert share exceptions to red… #15568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uce concurrency issues Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
bug
feature: api 🛠️
Comment on lines
+356
to
+372
| $this->dbConnection->beginTransaction(); | ||
| $inserted = $this->dbConnection->insertIfNotExist('*PREFIX*share', [ | ||
| 'share_type' => self::SHARE_TYPE_USERROOM, | ||
| 'share_with' => $recipient, | ||
| 'uid_owner' => $share->getShareOwner(), | ||
| 'uid_initiator' => $share->getSharedBy(), | ||
| 'parent' => $share->getId(), | ||
| 'item_type' => $share->getNodeType(), | ||
| 'item_source' => $share->getNodeId(), | ||
| 'file_source' => $share->getNodeId(), | ||
| 'file_target' => $share->getTarget(), | ||
| 'permissions' => 0, | ||
| 'stime' => $share->getShareTime()->getTimestamp(), | ||
| ], ['share_type', 'share_with', 'parent']); | ||
| $this->dbConnection->commit(); | ||
|
|
||
| if ($inserted === 0) { |
There was a problem hiding this comment.
Unfortunately wrapping insertIfNotExists in a transaction does not give more atomicity
There was a problem hiding this comment.
While that is sad, the reduced roundtrip time should help
And the change here in deleteFromSelf which updates ALL share_type+with+parent items instead of the first one found by ID should solve the issue we are facing at the moment:
- After using "Unshare from self" and reloading the page, the share is visible again.
- THat should be fixed, as now all items have permissions = 0 and are not mounted
miaulalala
approved these changes
Jul 23, 2025
ChristophWurst
approved these changes
Jul 23, 2025
nickvergessen
modified the milestones:
v22.0.0-beta.2,
🪺 Next RC (32),
🍏 Next Major (33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uce concurrency issues
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required