feat(FilenameValidator): allow to sanitize filenames

[susnux]

• Follow up on feat(files): add command to automatically rename filenames #51608

Summary

Share the filename sanitizing with the OCP filename validator.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Rello]

@susnux during a test it was figured out, that the wrong default replacement is being used. As per "standard", the "" should be the default and not the " ".
We can proceed the testing by setting the "", but for the final users, we want the changed default. can you please correct this?

@AndyScherzinger as discussed...

[susnux]

Not sure I understand this comment, which standard?
Which character should be the default replacement?

[AndyScherzinger]

@susnux the default is the underscore, for reference see https://support.microsoft.com/en-us/office/why-has-my-filename-changed-f14307b4-e9ff-4cd9-be79-9524bb323744

[Rello]

Not sure I understand this comment, which standard? Which character should be the default replacement?

Hi,

this means, if you run the occ without any parameters, it will use " " as the replacement - but it needs to be "_" unless the user chooses differently

[susnux]

Ah ok, makes sense. The _ was missing in the comment above as it makes the text italic on Markdown ;)

[Rello]

@susnux
there is one more topic that is showing up in clients - its Case Clashes.

Do you have a clever idea if this could also be covered in a cleanup run?

[susnux]

there is one more topic that is showing up in clients - its Case Clashes.

We excluded case issues when implementing as Windows (at least since Windows 10).
I expected that our Windows client automatically enables case-sensitivity on the synced folders?

Otherwise we need to also implement this which is much deeper in the server code than filename validation, probably somewhere on storage level like we do for some SAMBA storages where case sensitivity was not enabled.

[Rello]

I agree - the coding effort will be higher.
we would need to check every file against all files within the same folder.
It might be easier to leave it to the user to clean it up via the client. the client is giving a warning and a resolve-ui.

Cost-Benefit might not be positive here