Check Storage Permission Before Upload #15240
Conversation
alperozturk96
added
3. to review
ux-enhancement
alperozturk96
force-pushed
the
check-manage-all-files-permission
branch
from
38a609b to
92df4ea
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
|
Looks like full file access permission fixed the issue, please read the issue and comments. #15039 (comment) |
alperozturk96
force-pushed
the
check-manage-all-files-permission
branch
from
92df4ea to
d446815
Compare
alperozturk96
changed the title
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
check-manage-all-files-permission
branch
from
d83b4f9 to
b7be9b8
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15240.apk |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| .setAutoCancel(true) | ||
|
|
||
| ContextCompat.getSystemService(context, NotificationManager::class.java)?.run { | ||
| notify(MISSING_FILE_PERMISSION_NOTIFICATION_ID, notificationBuilder.build()) |
Check failure
Code scanning / CodeQL
Use of implicit PendingIntents High
Copilot Autofix
AI about 4 hours ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
Issue
Previously granted
MANAGE_EXTERNAL_STORAGEorOnly Media Accesspermission can be revoked if the app hasn't been used for a few months (e.g. if user not opens the app just using the app for auto upload) or after a system upgrade.Some other OS implementations may handle this differently, so we need to cover this edge case as well.
Also, it seems that some users have experienced this issue before and resolved it by re-granting the permission.
#15218 (comment)
#15039 (comment)
Changes
Notes
PermissionUtil.requestExternalStoragePermissioncannot be used to display the same permission dialog that appears at the beginning of the application, as it depends onAppCompatActivity. Therefore, we inform the user and provide them with the option to choose between the standard app permission or full file access.@ZetaTom
Additionally, instead of handling the error after a failed upload, we proactively check for the necessary permissions before initiating the upload. This approach prevents unnecessary calls and simplifies the logic flow.
All files access action
App permissions action
We cannot redirect to the directly to the storage permission page. There is no intent action for that.