Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jun 5, 2025

For ESLint we are doing the same due to missing consensus on moving to prettier and the already large user base of @nextcloud/eslint-config and @nextcloud/stylelint-config.

@susnux susnux requested review from ShGKme and artonge June 5, 2025 14:22
@susnux susnux added 3. to review Waiting for reviews enhancement New feature or request labels Jun 5, 2025
@ShGKme
Copy link
Contributor

ShGKme commented Jun 6, 2025

and the already large user base of @nextcloud/eslint-config

Speaking of that, ESLint is also capable of linting and formatting CSS

https://eslint.org/blog/2025/02/eslint-css-support/

@ShGKme
Copy link
Contributor

ShGKme commented Jun 6, 2025

Do we want to use stylelint to fix formating in <style> block in .vue files (which is kind of a JS module)?

@susnux
Copy link
Contributor Author

susnux commented Jun 7, 2025

Speaking of that, ESLint is also capable of linting and formatting CSS

IIRC and from reading it, the rules are still quite minimal.

Do we want to use stylelint to fix formating in <style> block in .vue files (which is kind of a JS module)?

We already did this in the past and doing it also currently, so I would not change it.


Basically this reverts only the Prettier decision as basically no app (except forms) that I know migrated and the standards RFC was never decided and it seems to be easier to revert back to also include stylistic for now.
As otherwise apps currently updated the config and now start to get more and more weird formatting in the styles due to missing rules (e.g. spaces vs tabs, missing spaces around arithmetic operations etc - all that stuff we enforced in the past already and should be enforced by prettier).

@susnux susnux force-pushed the feat/bring-back-stylistic-rules branch from 6006a89 to 82da67b Compare October 2, 2025 18:48
For ESLint we are doing the same due to missing consensus on moving to
prettier and the already large user base of `@nextcloud/eslint-config`
and `@nextcloud/stylelint-config`.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the feat/bring-back-stylistic-rules branch from 82da67b to c3aaba8 Compare October 2, 2025 18:49
@susnux susnux requested a review from ShGKme October 2, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants