Skip to content

chore: Refactor OTEL bridge signals setup #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jsumners-nr
Copy link
Contributor

@jsumners-nr jsumners-nr commented Jul 23, 2025

This PR resolves #3240.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

❌ Patch coverage is 98.86686% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.61%. Comparing base (960d169) to head (35408e5).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
lib/otel/setup-signal.js 89.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3244      +/-   ##
==========================================
- Coverage   97.66%   97.61%   -0.06%     
==========================================
  Files         345      347       +2     
  Lines       51757    51824      +67     
==========================================
+ Hits        50549    50587      +38     
- Misses       1208     1237      +29     
Flag Coverage Δ
integration-tests-cjs-20.x 73.95% <98.01%> (+0.02%) ⬆️
integration-tests-cjs-22.x 73.99% <98.01%> (+0.02%) ⬆️
integration-tests-cjs-24.x 74.73% <98.01%> (+0.02%) ⬆️
integration-tests-esm-20.x 49.46% <46.17%> (-0.01%) ⬇️
integration-tests-esm-22.x 49.53% <46.45%> (-0.01%) ⬇️
integration-tests-esm-24.x 51.24% <48.15%> (+<0.01%) ⬆️
unit-tests-20.x 88.31% <78.18%> (+<0.01%) ⬆️
unit-tests-22.x 88.32% <78.18%> (+<0.01%) ⬆️
unit-tests-24.x 88.36% <78.18%> (+<0.01%) ⬆️
versioned-tests-20.x 80.24% <70.82%> (-0.18%) ⬇️
versioned-tests-22.x 80.25% <70.82%> (-0.18%) ⬇️
versioned-tests-24.x 80.15% <70.82%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bizob2828 bizob2828 self-assigned this Jul 24, 2025
refactor metrics setup

refactor logs setup
@jsumners-nr jsumners-nr marked this pull request as ready for review August 5, 2025 12:30
@jsumners-nr jsumners-nr added the dev:repo_maintenance PRs that don't need to be included in release notes or trigger a pending release notification. label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:repo_maintenance PRs that don't need to be included in release notes or trigger a pending release notification.
Projects
Status: Needs PR Review
Development

Successfully merging this pull request may close these issues.

Refactor OTEL bootstrapping
2 participants