Skip to content

Add filter alias support to layer/subscription commands #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2020
Merged

Add filter alias support to layer/subscription commands #70

merged 2 commits into from
Feb 18, 2020

Conversation

@kolanos
Copy link
Contributor

@kolanos kolanos commented Feb 18, 2020 •
edited
Loading

  • Adds support for all, installed and not-installed filter aliases to the layer and subscription commands
  • Adds a --exclude argument to exclude functions when using filter aliases

Closes #69

@kolanos kolanos changed the title Add alias support to layer/subscription commands Add filter alias support to layer/subscription commands Feb 18, 2020
@kolanos kolanos self-assigned this Feb 18, 2020
MattWhelan
MattWhelan approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@MattWhelan MattWhelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kolanos kolanos merged commit 76b8644 into master Feb 18, 2020
@kolanos kolanos deleted the filter-aliases branch February 18, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ewindisch ewindisch Awaiting requested review from ewindisch

@hmacdonald-nr hmacdonald-nr Awaiting requested review from hmacdonald-nr

@katiebayes katiebayes Awaiting requested review from katiebayes

@katiewest820 katiewest820 Awaiting requested review from katiewest820

@mrickard mrickard Awaiting requested review from mrickard

1 more reviewer

@MattWhelan MattWhelan MattWhelan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kolanos kolanos

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

not-installed filter doesn't seem to work

3 participants

@kolanos @MattWhelan