Skip to content

Conversation

@aavinash-nr
Copy link
Contributor

@aavinash-nr aavinash-nr commented May 9, 2025

Description:

  • This PR Resolves the issue that env handler is getting upgraded during upgrade command

Tests Done:

During Initial Installation (without --esm):

  • The Lambda handler is updated to newrelic-lambda-wrapper.handler.
  • The handler environment variable is updated.

During Initial Installation (with --esm):

  • The Lambda handler is updated to /opt/nodejs/node_modules/newrelic-esm-lambda-wrapper/index.handler.
  • The handler environment variable is updated.

During Upgrade (from a non-ESM setup to ESM) :

  • The Lambda handler is updated to /opt/nodejs/node_modules/newrelic-esm-lambda-wrapper/index.handler.
  • The handler environment variable is not updated.

During Upgrade (from an ESM setup to non-ESM):

  • The Lambda handler is updated to newrelic-lambda-wrapper.handler.
  • The handler environment variable is not updated.

During Initial Installation for ruby and python function

  • The Lambda handler is updated to newrelic_lambda_wrapper.handler.
  • The handler environment variable is updated.

During Upgrade for ruby and python function

  • The Lambda handler is updated to newrelic_lambda_wrapper.handler.
  • The handler environment variable is not updated.

@aavinash-nr aavinash-nr requested a review from chaudharysaket May 9, 2025 06:49
@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.52%. Comparing base (d340bb0) to head (1a21501).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
+ Coverage   75.47%   75.52%   +0.04%     
==========================================
  Files          18       18              
  Lines        1574     1577       +3     
==========================================
+ Hits         1188     1191       +3     
  Misses        386      386              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chaudharysaket chaudharysaket merged commit 930f72b into newrelic:main May 19, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants