Kwest/lambda 1197 #171
Kwest/lambda 1197 #171
Conversation
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 76.96% 77.09% +0.13%
==========================================
Files 16 16
Lines 1211 1227 +16
==========================================
+ Hits 932 946 +14
- Misses 279 281 +2
Continue to review full report at Codecov.
|
| lk_stack_status = _get_cf_stack_status(input.session, LICENSE_KEY_STACK_NAME) | ||
| lk_stack_status = _get_cf_stack_status( | ||
| input.session, LICENSE_KEY_STACK_NAME, input.nr_account_id | ||
| ) |
There was a problem hiding this comment.
A user who has an existing secret with no outputs (because they used an older CLI) will show up as having the stack, and will see the warning, right? We should probably think about how to avoid having them see the warning forever.
There was a problem hiding this comment.
Not totally following you here. Also, Is that something we want to solve in this ticket?
There was a problem hiding this comment.
This is an upgrade scenario: user has an existing, working install, and they do an upgrade. They should not get a warning message. So the test case would look like:
- Install a region with CLI version 0.5.5.
- Run an upgrade with CLI version
- Ensure that this happy-path upgrade doesn't generate a warning message.
There was a problem hiding this comment.
Also, speaking of versions, we should change the version in setup.py to 0.6.0 or something :)
There was a problem hiding this comment.
Ahh yes, I'm tracking now.
Per meeting on Tuesday:
https://newrelic.atlassian.net/browse/LAMBDA-1197