Skip to content

Conversation

@kolanos
Copy link
Contributor

@kolanos kolanos commented Feb 9, 2021

In addition to surfacing an existing cloud integration's IAM role ARN if found, this change also cleans up the lookup logic for cloud integrations in general to make it based on IDs instead of names. Link account names have been problematic as they are arbitrary and are not unique.

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #150 (983d4d6) into master (8478195) will increase coverage by 10.02%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #150       +/-   ##
===========================================
+ Coverage   54.31%   64.33%   +10.02%     
===========================================
  Files          10       10               
  Lines         580      600       +20     
===========================================
+ Hits          315      386       +71     
+ Misses        265      214       -51     
Impacted Files Coverage Δ
newrelic_lambda_cli/utils.py 69.35% <70.00%> (+0.12%) ⬆️
newrelic_lambda_cli/api.py 58.38% <86.66%> (+40.65%) ⬆️
newrelic_lambda_cli/cli/integrations.py 90.26% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8478195...983d4d6. Read the comment docs.

@kolanos kolanos marked this pull request as ready for review February 9, 2021 19:52
@kolanos kolanos self-assigned this Feb 9, 2021
@kolanos kolanos merged commit 908e857 into master Feb 10, 2021
@kolanos kolanos deleted the lambda/1004 branch February 10, 2021 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants