Ignore Frame ACKs when the encoder is deleted #3600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore late frame ACKs from the client if the encoder is mssing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3590
Tested informally by @roffery
Ignore late frame ACKs from the client if the encoder is missing.
This was observed using the RFX codec when resizing the display. While the display is being resized, the encoder can be deleted. If a later frame ack arrives at this point, a SEGV is generated as
self->encoderis NULL inxrdp_mm.c.If the situation occurs now, we generate a debug log message and ACK all frames from the module. The last action shouldn't really be necessary as this happens anyway later in the resize, but it seemed a sensible thing to do.
@jsorg71, @Nexarian - I think you both understand frame ACKs better than I do. Does this look OK to you?