[V0.10] Remove SIGTERM race in chansrv #3482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signal handlers for SIGTERM are put in place before the sigterm object is created. If a SIGTERM is received between the two, it is ignored and chansrv will not exit. (cherry picked from commit 343e84a)
|
I have no time to look into this before the v0.10.3 release, let's merge this after v0.10.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signal handlers for SIGTERM are put in place before the sigterm object is created. If a SIGTERM is received between the two, it is ignored and chansrv will not exit.
(cherry picked from commit 343e84a)
@metalefty - this is a minor issue for V0.10.x and probably isn't a priority for v0.10.3 now. It can go into v0.10.4. I found it while I was testing some improvements to sesexec.