MSTSC crashes when resolution is changed by maximizing on a different monitor

[okhowang]

I have two monitors with 2560x1440 and 1920x1080 resolution.

and setting mstsc to use one monitor for full screen mode.

when I drag mstsc from a monitor to another, error occurred as below.

It means internal error.

and will got log

==> /home/.xorgxrdp.12.log <==
[1135171.145] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 2560 cy 1440
[1135171.145] rdpClientConProcessMsgVersion: version 0 0 0 1
[1135171.145] rdpClientConProcessScreenSizeMsg: set width 2560 height 1440 bpp 32
[1135171.146] rdpClientConProcessScreenSizeMsg: shmemid 254443553 shmemptr 0x7f5f87b3a000
[1135171.146] rdpRRScreenSetSize: width 2560 height 1440 mmWidth 677 mmHeight 381
[1135171.151] rdpRRGetInfo:
[1135171.151]   screen resized to 2560x1440
[1135171.157] rdpClientConProcessScreenSizeMsg: RRScreenSizeSet ok=[1]
[1135171.157] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 2560 cy 1440
[1135171.157] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 2560 cy 1440
[1135171.158] rdpClientConProcessMsgVersion: version 0 0 0 1
[1135171.158] rdpClientConProcessScreenSizeMsg: set width 2560 height 1440 bpp 32
[1135171.158] rdpClientConProcessScreenSizeMsg: shmemid 254476321 shmemptr 0x7f5f87b3a000
[1135171.158] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 2560 cy 1440
[1135171.158] rdpClientConProcessMsgClientInfo:
[1135171.158]   got client info bytes 7064
[1135171.158]   jpeg support 0
[1135171.158]   offscreen support 1
[1135171.158]   offscreen size 10485760
[1135171.158]   offscreen entries 100
[1135171.158] rdpClientConProcessMsgClientInfo: got RFX capture
[1135171.158]   cap_width 2560 cap_height 1472
[1135171.158] rdpClientConProcessMsgClientInfo: shmemid 254509089 shmemptr 0x7f5f87aea000 bytes 15073280
[1135171.158]   client can not do offscreen to offscreen blits
[1135171.158]   client can do new(color) cursor
[1135171.158]   client can not do multimon
[1135171.158] rdpRRSetRdpOutputs: numCrtcs 1 numOutputs 1 monitorCount 0
[1135171.158] rdpRRSetRdpOutputs: update output 0 left 0 top 0 width 2560 height 1440
[1135171.158] rdpRRUpdateOutput:
[1135171.159] rdpLoadLayout: keylayout 0x00000804 variant  display 12
[1135171.159] rdpkeybChangeKeyboardControl:
[1135171.159] rdpkeybChangeKeyboardControl: autoRepeat on
[1135171.159] rdpkeybChangeKeyboardControl:
[1135171.160] rdpkeybChangeKeyboardControl: autoRepeat on
[1135171.160] rdpClientConProcessMsgClientInfo:
[1135171.160]   got client info bytes 7064
[1135171.160]   jpeg support 0
[1135171.160]   offscreen support 1
[1135171.160]   offscreen size 10485760
[1135171.160]   offscreen entries 100
[1135171.160] rdpClientConProcessMsgClientInfo: got RFX capture
[1135171.160]   cap_width 2560 cap_height 1472
[1135171.160] rdpClientConProcessMsgClientInfo: shmemid 254541857 shmemptr 0x7f5f87aea000 bytes 15073280
[1135171.160]   client can not do offscreen to offscreen blits
[1135171.161]   client can do new(color) cursor
[1135171.161]   client can not do multimon
[1135171.161] rdpRRSetRdpOutputs: numCrtcs 1 numOutputs 1 monitorCount 0
[1135171.161] rdpRRSetRdpOutputs: update output 0 left 0 top 0 width 2560 height 1440
[1135171.161] rdpRRUpdateOutput:
[1135171.161] rdpLoadLayout: keylayout 0x00000804 variant  display 12
[1135171.161] rdpkeybChangeKeyboardControl:
[1135171.161] rdpkeybChangeKeyboardControl: autoRepeat on
[1135171.161] rdpkeybChangeKeyboardControl:
[1135171.161] rdpkeybChangeKeyboardControl: autoRepeat on
[1135171.240] rdpRRGetInfo:
[1135171.259] rdpInDeferredRepeatCallback:
[1135171.259] rdpkeybChangeKeyboardControl:
[1135171.259] rdpkeybChangeKeyboardControl: autoRepeat off
[1135171.260] rdpRRGetInfo:
[1135171.260] rdpInDeferredRepeatCallback:
[1135171.260] rdpkeybChangeKeyboardControl:
[1135171.260] rdpkeybChangeKeyboardControl: autoRepeat off
[1135171.268] rdpInDeferredRepeatCallback:
[1135171.268] rdpkeybChangeKeyboardControl:
[1135171.268] rdpkeybChangeKeyboardControl: autoRepeat off
[1135171.268] rdpInDeferredRepeatCallback:
[1135171.268] rdpkeybChangeKeyboardControl:
[1135171.268] rdpkeybChangeKeyboardControl: autoRepeat off
[1135171.273] rdpRRGetInfo:

==> /var/log/xrdp.log <==
[20210623-15:44:38] [INFO ] xrdp_caps_process_pointer: client supports new(color) cursor
[20210623-15:44:38] [INFO ] xrdp_process_offscreen_bmpcache: support level 1 cache size 10485760 MB cache entries 100
[20210623-15:44:38] [INFO ] xrdp_caps_process_codecs: nscodec, codec id 1, properties len 3
[20210623-15:44:38] [WARN ] xrdp_caps_process_codecs: unknown codec id 5
[20210623-15:44:38] [INFO ] xrdp_caps_process_codecs: RemoteFX, codec id 3, properties len 49

==> /home/.xorgxrdp.12.log <==
[1135171.458] KbdSync: toggling num lock
[1135171.458] rdpkeybChangeKeyboardControl:
[1135171.458] rdpkeybChangeKeyboardControl: autoRepeat off
[1135171.458] rdpkeybChangeKeyboardControl:
[1135171.458] rdpkeybChangeKeyboardControl: autoRepeat off
[1135171.486] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 2559 cy 1439

==> /var/log/xrdp.log <==
[20210623-15:44:38] [ERROR] SSL_read: I/O error
[20210623-15:44:38] [ERROR] xrdp_iso_send: trans_write_copy_s failed
[20210623-15:44:38] [ERROR] SSL_shutdown: I/O error
[20210623-15:44:38] [ERROR] Sending [ITU T.125] DisconnectProviderUltimatum failed

==> /home/.xorgxrdp.12.log <==
[1135171.521] rdpClientConRecv: g_sck_recv failed(returned -1)
[1135171.521] rdpClientConRecvMsg: error
[1135171.521] rdpClientConCheck: rdpClientConGotData failed
[1135171.525] rdpClientConDisconnect:
[1135171.525] rdpRemoveClientConFromDev: removing clientCon 0x55644bb73110

[matt335672]

These errors from xrdp mean the other client has gone away unexpectedly:-

[20210623-15:44:38] [ERROR] SSL_read: I/O error
[20210623-15:44:38] [ERROR] xrdp_iso_send: trans_write_copy_s failed
[20210623-15:44:38] [ERROR] SSL_shutdown: I/O error
[20210623-15:44:38] [ERROR] Sending [ITU T.125] DisconnectProviderUltimatum failed

So something is happening which is upsetting mstsc.exe, but it's not clear what.

I've got a twin-screen Windows 10 VM set up as you have above, and I'm unable to reproduce your crash. Windows version here is 21H1 (OS build 19043.1052), and I'm using a development build of xrdp.

What platforms are you using? Are you using a .ini file to start the connection?

[okhowang]

my windows version 21H1 19043.1023.
and I use mstsc without .ini file.

I've got a twin-screen Windows 10 VM set up as you have above, and I'm unable to reproduce your crash.

are your twin-screen have different resolution?
and are your start mstsc with fullscreen?

I will try other rdp client later

[matt335672]

Yes - that's what I've got. My dialog looks like yours, but in English rather than Chinese. Since it's a VM I've set my screen resolutions to match yours.

A couple of other questions for you:-

• What version of xrdp are you connecting to? I can rebuild that end and try again.
• Do you have another Windows machine you can connect to from mstsc.exe ?

[okhowang]

What version of xrdp are you connecting to? I can rebuild that end and try again.

xrdp version 0.9.15

Do you have another Windows machine you can connect to from mstsc.exe ?

I try another windows machine (21H1 19043.1055) mstsc.exe. and there was no internal error.

my windows version 21H1 19043.1023.

it is a client-side bug. I will try to upgrade this machine and try again.

[okhowang]

I will try to upgrade this machine and try again.

crash remained after upgrading system version.

I compare two machine's mstsc, and found that options determine crashing or not.

if select LAN, it will be crash.
if select auto detected, it will be ok.

[metalefty]

Can you also confirm with 16bpp color * "LAN", "Auto detect"?

[okhowang]

Can you also confirm with 16bpp color * "LAN", "Auto detect"?

16bpp is ok for LAN and Auto detect, no internal error

[matt335672]

I've reproduced this by using a LAN setting and 24bpp colour.

The debug logs are required to get some idea of what's going on. Here's what I've got so far from xrdp:-

xrdp.log

[20211119-11:57:10] [DEBUG] [dynamic_monitor_data(xrdp_mm.c:1080)] dynamic_monitor_data: msg_type 2 msg_length 56
[20211119-11:57:10] [DEBUG] [dynamic_monitor_data(xrdp_mm.c:1092)]   MonitorLayoutSize 40 NumMonitor 1
[20211119-11:57:10] [DEBUG] [dynamic_monitor_data(xrdp_mm.c:1107)]     Flags 0x00000001 Left 0 Top 0 Width 1920 Height 1200 PhysicalWidth 637 PhysicalHeight 421 Orientation 0 DesktopScaleFactor 100 DeviceScaleFactor 100
[20211119-11:57:10] [DEBUG] [libxrdp_send_pointer(libxrdp.c:719)] sending cursor
[20211119-11:57:10] [DEBUG] [libxrdp_send_pointer(libxrdp.c:747)] libxrdp_send_pointer: fastpath
[20211119-11:57:10] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:785)] xrdp_rdp_send_fastpath: no_comp_len 3221, fragmentation 0
[20211119-11:57:10] [DEBUG] [xrdp_sec_send_fastpath(xrdp_sec.c:1921)] xrdp_sec_send_fastpath: no crypt
[20211119-11:57:10] [DEBUG] [libxrdp_send_pointer(libxrdp.c:719)] sending cursor
[20211119-11:57:10] [DEBUG] [libxrdp_send_pointer(libxrdp.c:747)] libxrdp_send_pointer: fastpath
[20211119-11:57:10] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:785)] xrdp_rdp_send_fastpath: no_comp_len 3221, fragmentation 0
[20211119-11:57:10] [DEBUG] [xrdp_sec_send_fastpath(xrdp_sec.c:1921)] xrdp_sec_send_fastpath: no crypt
[20211119-11:57:10] [DEBUG] [xrdp_painter_create(xrdp_painter.c:140)] xrdp_painter_create:
[20211119-11:57:10] [DEBUG] [xrdp_painter_begin_update(xrdp_painter.c:243)] xrdp_painter_begin_update:
[20211119-11:57:10] [DEBUG] [xrdp_orders_init(xrdp_orders.c:110)] xrdp_orders_init: fastpath
[20211119-11:57:10] [DEBUG] [wm_painter_set_target(xrdp_painter.c:193)] wm_painter_set_target:
[20211119-11:57:10] [DEBUG] [xrdp_painter_end_update(xrdp_painter.c:265)] xrdp_painter_end_update:
[20211119-11:57:10] [DEBUG] [xrdp_painter_delete(xrdp_painter.c:171)] xrdp_painter_delete:
[20211119-11:57:10] [DEBUG] [send_server_monitor_resize(xup.c:1307)] send_server_monitor_resize: sent resize message with following properties to xorgxrdp backend width=1920, height=1200, bpp=24, return value=0
[20211119-11:57:10] [DEBUG] [send_server_monitor_full_invalidate(xup.c:1334)] send_server_monitor_full_invalidate: sent invalidate message with following properties to xorgxrdp backend width=1920, height=1200, return value=0
[20211119-11:57:10] [DEBUG] [xrdp_rdp_recv(xrdp_rdp.c:519)] xrdp_rdp_recv: out code 0 (skip data) data processed by channel id 1007
[20211119-11:57:10] [DEBUG] [lib_mod_process_orders(xup.c:1386)] lib_mod_process_orders: type 1
[20211119-11:57:11] [DEBUG] [xrdp_painter_create(xrdp_painter.c:140)] xrdp_painter_create:
[20211119-11:57:11] [DEBUG] [xrdp_painter_begin_update(xrdp_painter.c:243)] xrdp_painter_begin_update:
[20211119-11:57:11] [DEBUG] [xrdp_orders_init(xrdp_orders.c:110)] xrdp_orders_init: fastpath
[20211119-11:57:11] [DEBUG] [wm_painter_set_target(xrdp_painter.c:193)] wm_painter_set_target:
[20211119-11:57:11] [DEBUG] [lib_mod_process_orders(xup.c:1386)] lib_mod_process_orders: type 61
[20211119-11:57:11] [DEBUG] [server_paint_rects(xrdp_mm.c:3192)] server_paint_rects: 0x55ae03f16af0
[20211119-11:57:11] [DEBUG] [lib_mod_process_orders(xup.c:1386)] lib_mod_process_orders: type 2
[20211119-11:57:11] [DEBUG] [xrdp_painter_end_update(xrdp_painter.c:265)] xrdp_painter_end_update:
[20211119-11:57:11] [DEBUG] [process_enc_rfx(xrdp_encoder.c:329)] process_enc_rfx:
[20211119-11:57:11] [DEBUG] [process_enc_rfx(xrdp_encoder.c:330)] process_enc_rfx: num_crects 3 num_drects 1
[20211119-11:57:11] [DEBUG] [xrdp_painter_delete(xrdp_painter.c:171)] xrdp_painter_delete:
[20211119-11:57:11] [DEBUG] [process_enc_rfx(xrdp_encoder.c:393)] process_enc_rfx: rfxcodec_encode rv 0
[20211119-11:57:11] [DEBUG] [dynamic_monitor_data(xrdp_mm.c:1080)] dynamic_monitor_data: msg_type 2 msg_length 56
[20211119-11:57:11] [DEBUG] [dynamic_monitor_data(xrdp_mm.c:1092)]   MonitorLayoutSize 40 NumMonitor 1
[20211119-11:57:11] [DEBUG] [dynamic_monitor_data(xrdp_mm.c:1107)]     Flags 0x00000001 Left 0 Top 0 Width 1920 Height 1200 PhysicalWidth 637 PhysicalHeight 421 Orientation 0 DesktopScaleFactor 100 DeviceScaleFactor 100
[20211119-11:57:11] [DEBUG] [libxrdp_send_pointer(libxrdp.c:719)] sending cursor
[20211119-11:57:11] [DEBUG] [libxrdp_send_pointer(libxrdp.c:747)] libxrdp_send_pointer: fastpath
[20211119-11:57:11] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:785)] xrdp_rdp_send_fastpath: no_comp_len 3221, fragmentation 0
[20211119-11:57:11] [DEBUG] [xrdp_sec_send_fastpath(xrdp_sec.c:1921)] xrdp_sec_send_fastpath: no crypt
[20211119-11:57:11] [DEBUG] [libxrdp_send_pointer(libxrdp.c:719)] sending cursor
[20211119-11:57:11] [DEBUG] [libxrdp_send_pointer(libxrdp.c:747)] libxrdp_send_pointer: fastpath
[20211119-11:57:11] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:785)] xrdp_rdp_send_fastpath: no_comp_len 3221, fragmentation 0
[20211119-11:57:11] [DEBUG] [xrdp_sec_send_fastpath(xrdp_sec.c:1921)] xrdp_sec_send_fastpath: no crypt
[20211119-11:57:11] [DEBUG] [xrdp_painter_create(xrdp_painter.c:140)] xrdp_painter_create:
[20211119-11:57:11] [DEBUG] [xrdp_painter_begin_update(xrdp_painter.c:243)] xrdp_painter_begin_update:
[20211119-11:57:11] [DEBUG] [xrdp_orders_init(xrdp_orders.c:110)] xrdp_orders_init: fastpath
[20211119-11:57:11] [DEBUG] [wm_painter_set_target(xrdp_painter.c:193)] wm_painter_set_target:
[20211119-11:57:12] [DEBUG] [xrdp_painter_end_update(xrdp_painter.c:265)] xrdp_painter_end_update:
[20211119-11:57:12] [DEBUG] [xrdp_painter_delete(xrdp_painter.c:171)] xrdp_painter_delete:
[20211119-11:57:12] [DEBUG] [send_server_monitor_resize(xup.c:1307)] send_server_monitor_resize: sent resize message with following properties to xorgxrdp backend width=1920, height=1200, bpp=24, return value=0
[20211119-11:57:12] [DEBUG] [send_server_monitor_full_invalidate(xup.c:1334)] send_server_monitor_full_invalidate: sent invalidate message with following properties to xorgxrdp backend width=1920, height=1200, return value=0
[20211119-11:57:12] [DEBUG] [xrdp_rdp_recv(xrdp_rdp.c:519)] xrdp_rdp_recv: out code 0 (skip data) data processed by channel id 1007
[20211119-11:57:12] [DEBUG] [xrdp_mm_process_enc_done(xrdp_mm.c:2815)] xrdp_mm_process_enc_done: message back bytes 2914
[20211119-11:57:12] [DEBUG] [libxrdp_fastpath_send_frame_marker(libxrdp.c:1723)] libxrdp_fastpath_send_frame_marker:
[20211119-11:57:12] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:785)] xrdp_rdp_send_fastpath: no_comp_len 12, fragmentation 0
[20211119-11:57:12] [DEBUG] [xrdp_sec_send_fastpath(xrdp_sec.c:1921)] xrdp_sec_send_fastpath: no crypt
[20211119-11:57:12] [DEBUG] [libxrdp_fastpath_send_surface(libxrdp.c:1641)] libxrdp_fastpath_send_surface:
[20211119-11:57:12] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:785)] xrdp_rdp_send_fastpath: no_comp_len 2940, fragmentation 0
[20211119-11:57:12] [DEBUG] [compress_rdp_5(xrdp_mppc_enc.c:972)] Compression algorithim produced a compressed buffer which is larger than the uncompressed buffer. compression ratio 0.979646, flags 0x1
[20211119-11:57:12] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:810)] compress_rdp failed, sending uncompressed data. type 2, flags 1
[20211119-11:57:12] [DEBUG] [xrdp_sec_send_fastpath(xrdp_sec.c:1921)] xrdp_sec_send_fastpath: no crypt
[20211119-11:57:12] [DEBUG] [libxrdp_fastpath_send_frame_marker(libxrdp.c:1723)] libxrdp_fastpath_send_frame_marker:
[20211119-11:57:12] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:785)] xrdp_rdp_send_fastpath: no_comp_len 12, fragmentation 0
[20211119-11:57:12] [DEBUG] [xrdp_sec_send_fastpath(xrdp_sec.c:1921)] xrdp_sec_send_fastpath: no crypt
[20211119-11:57:12] [ERROR] [ssl_tls_log_error(ssl_calls.c:655)] SSL_write: I/O error
[20211119-11:57:12] [ERROR] [xrdp_sec_send_fastpath(xrdp_sec.c:1936)] xrdp_sec_send_fastpath: xrdp_fastpath_send failed
[20211119-11:57:12] [ERROR] [xrdp_rdp_send_fastpath(xrdp_rdp.c:834)] xrdp_rdp_send_fastpath: xrdp_sec_send_fastpath failed
[20211119-11:57:13] [ERROR] [libxrdp_fastpath_send_frame_marker(libxrdp.c:1749)] libxrdp_fastpath_send_frame_marker: xrdp_rdp_send_fastpath failed
[20211119-11:57:13] [DEBUG] [xrdp_mm_process_enc_done(xrdp_mm.c:2838)] xrdp_mm_process_enc_done: last set
[20211119-11:57:13] [DEBUG] [xrdp_mm_update_module_frame_ack(xrdp_mm.c:2785)] xrdp_mm_update_module_ack: frame_id_server 10
[20211119-11:57:13] [DEBUG] [lib_mod_process_orders(xup.c:1386)] lib_mod_process_orders: type 1
[20211119-11:57:13] [DEBUG] [xrdp_painter_create(xrdp_painter.c:140)] xrdp_painter_create:
[20211119-11:57:13] [DEBUG] [xrdp_painter_begin_update(xrdp_painter.c:243)] xrdp_painter_begin_update:
[20211119-11:57:13] [DEBUG] [xrdp_orders_init(xrdp_orders.c:110)] xrdp_orders_init: fastpath
[20211119-11:57:13] [DEBUG] [wm_painter_set_target(xrdp_painter.c:193)] wm_painter_set_target:
[20211119-11:57:13] [DEBUG] [lib_mod_process_orders(xup.c:1386)] lib_mod_process_orders: type 51
[20211119-11:57:13] [DEBUG] [libxrdp_send_pointer(libxrdp.c:719)] sending cursor
[20211119-11:57:13] [DEBUG] [libxrdp_send_pointer(libxrdp.c:747)] libxrdp_send_pointer: fastpath
[20211119-11:57:13] [DEBUG] [xrdp_rdp_send_fastpath(xrdp_rdp.c:785)] xrdp_rdp_send_fastpath: no_comp_len 4245, fragmentation 0
[20211119-11:57:13] [DEBUG] [xrdp_sec_send_fastpath(xrdp_sec.c:1921)] xrdp_sec_send_fastpath: no crypt
[20211119-11:57:13] [ERROR] [xrdp_sec_send_fastpath(xrdp_sec.c:1936)] xrdp_sec_send_fastpath: xrdp_fastpath_send failed

All I can say at the moment is something seems to be going wrong in xrdp_rdp_send_fastpath() following the resize. I've not been able to get any further yet.

[Nexarian]

The code that is in XRDP currently for resize is a shadow of what I have now after working with Jay to get that enabled for the GFX branch. There are some fixes I have where I've refactored resizing into a state machine and also been much more aggressive about making sure that duplicate resizes don't happen, and blocked the bug that I describe below.

It looks like this is somewhat related to a bug where, on initial connection, an X * Y resize is also sent over the dynamic display channel even though it's not necessary. In the past XRDP has had many issues with a resize-to-a-resolution-you're-already-at message.

@matt335672 I'm happy to help debug this if you can elucidate some clear steps to reproduce. We could also jump on a Zoom call and look at it together.

[matt335672]

Thanks @Nexarian - that's a great offer.

The crash doesn't happen when 'auto' is selected on the mstsc experience tab, so I need to work out exactly which option(s) is/are causing this to happen. I picked up on this late yesterday, so didn't have time for a lot of analysis. Also, when DEBUG logging is selected in development mode, things slow to a crawl.

After the weekend I'll do some analysis and post the info here. At the least I'm sure you'll want to check the GFX branch isn't affected.

[matt335672]

No real progress on this this week. I've managed to cause a couple of crashes with xfreerdp but they don't seem to be related to this one!

The only way I can reproduce it currently is with a twin monitor setup on Windows. Monitors are different sizes. Procedure is as follows:-

• Set LAN (10mbps or higher) on the experience tab
• Set display to full screen, but don't "use all monitors"
• Connect to xrdp, and log in as Xorg 24-bit.
• Unmaximise the window and drag it to the other monitor
• Maximise the window

I'll carry on trying to reproduce it with remmina or xfreerdp next week.

[matt335672]

I've found one reason why this is happening.

When the screen resizes, the xorgxrdp driver enters rdpClientConProcessScreenSizeMsg() twice. The shared memory Id changes twice as a result:-

[ 11703.161] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1920 cy 1200
[ 11703.161] rdpClientConProcessMsgVersion: version 0 0 0 1
[ 11703.161] rdpClientConProcessScreenSizeMsg: set width 1920 height 1200 bpp 24
[ 11703.162] rdpClientConProcessScreenSizeMsg: shmemid 98335 shmemptr 0x7fdd99533000
[ 11703.162] rdpRRScreenSetSize: width 1920 height 1200 mmWidth 508 mmHeight 318
[ 11703.162] rdpRRGetInfo:
[ 11703.162]   screen resized to 1920x1200
[ 11703.162] rdpClientConProcessScreenSizeMsg: RRScreenSizeSet ok=[1]
[ 11703.164] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1920 cy 1200
[ 11703.164] rdpClientConProcessMsgClientInfo:
[ 11703.164]   got client info bytes 7072
[ 11703.164]   jpeg support 0
[ 11703.164]   offscreen support 1
[ 11703.164]   offscreen size 7864320
[ 11703.164]   offscreen entries 100
[ 11703.164]   client can not do offscreen to offscreen blits
[ 11703.164]   client can do new(color) cursor
[ 11703.164]   client can not do multimon
[ 11703.164] rdpRRSetRdpOutputs: numCrtcs 1 numOutputs 1 monitorCount 0
[ 11703.164] rdpRRSetRdpOutputs: update output 0 left 0 top 0 width 1920 height 1200
[ 11703.164] rdpRRUpdateOutput:
[ 11703.165] rdpLoadLayout: keylayout 0x00000809 variant  display 12
[ 11703.165] rdpkeybChangeKeyboardControl:
[ 11703.165] rdpkeybChangeKeyboardControl: autoRepeat on
[ 11703.166] rdpkeybChangeKeyboardControl:
[ 11703.166] rdpkeybChangeKeyboardControl: autoRepeat on
[ 11703.174] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1920 cy 1200
[ 11703.175] rdpClientConProcessMsgVersion: version 0 0 0 1
[ 11703.175] rdpClientConProcessScreenSizeMsg: set width 1920 height 1200 bpp 24
[ 11703.176] rdpClientConProcessScreenSizeMsg: shmemid 98336 shmemptr 0x7fdd99533000
[ 11703.176] rdpClientConProcessMsgClientInput: invalidate x 0 y 0 cx 1920 cy 1200
[ 11703.177] rdpClientConRecv: g_sck_recv failed(returned -1)

In this example the shared memory ID changes to 98335, and then to 98336.

The xup routine process_server_paint_rect_shmem_ex() then gets a call to draw into shared memory ID 98335. It tries to map this, and fails, as it no longer exists. As a result, the call exits with an error.

Fix is probably not to re-allocate the memory region if it will be exactly the same size. I'll add a PR for this tomorrow to xorgxrdp for review.

[matt335672]

After retesting with neutrinolabs/xorgxrdp#203, I've found that there are other causes for this problem.

neutrinolabs/xorgxrdp#203 seems to fix the problem provided I build without RFX enabled. Once RFX is enabled, the client exits on resize after sending a TS_CONFIRM_ACTIVE_PDU. I'll carry on digging.