Avoid potential infinite loop for rdpUpdate. #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When frame acknowledgement is enabled, such as with the prototype of egfx, the driver is at risk of going into an infinite loop if for some reason an ack is missed. While this line could fix it from xrdp: `mm->mod->mod_frame_ack(mm->mod, 0, INT_MAX);`, the driver needs to be stable by itself. The rationale here is that this is akin to a network socket timeout. After a certain wait, it gives up. Same here. Also, frame acknowledgement is a quality of service feature, and is not strictly necessary for the functionality of remote desktop. In the worst case, bandwidth calcuations between client and server are temporarily incorrect. 200 was selected after some empirical testing, it could be tweaked.
metalefty
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When frame acknowledgement is enabled, such as with the prototype of
egfx, the driver is at risk of going into an infinite loop if for some
reason an ack is missed.
While this line could fix it from xrdp:
mm->mod->mod_frame_ack(mm->mod, 0, INT_MAX);,the driver needs to be stable by itself.
The rationale here is that this is akin to a network socket timeout.
After a certain wait, it gives up. Same here.
Also, frame acknowledgement is a quality of service feature, and is not
strictly necessary for the functionality of remote desktop. In the worst
case, bandwidth calcuations between client and server are temporarily
incorrect.
200 was selected after some empirical testing, it could be tweaked.
Testing