Skip to content

bugfix: remove /usr/share + "runner:root" CI workaround #6844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Jul 31, 2025

This reverts commit d54f798 ("bugfix: fcopy: add /usr/share +
"runner:root" exception to fix CI (#6803)", 2025-07-07).

After reporting the issue to GitHub, the CI test jobs are now working
even for 0.9.74[1] and it seems that /usr/share and /opt are owned by
root:root again[2] [3]:

drwxrwxrwx+ 214 root root 4096 Jul 20 22:00 /usr/share
drwxrwxrwx+  14 root root 4096 Jul 20 23:01 /opt

This is apparently resolved as of the ubuntu-22.04 image version
20250720.1[3] [4] [5].

Relates to #1531 #6797.

[1] https://github.com/netblue30/firejail/actions/runs/16638617665
[2] actions/runner-images#12526
[3] actions/runner-images#12526 (comment)
[4] https://github.com/actions/runner-images/blob/ubuntu22/20250720.1/images/ubuntu/Ubuntu2204-Readme.md
[5] https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20250720.1

@kmk3 kmk3 added the bugfix This fixes a bug label Jul 31, 2025
kmk3 added a commit to kmk3/firejail that referenced this pull request Jul 31, 2025
The `codeql-cpp` CI job for netblue30#6844 is failing[1]:

    ##[group]Setup CodeQL tools
    [...]
    Did not find CodeQL tools version 2.22.2 in the toolcache.
    Using CodeQL CLI version 2.22.2 sourced from https://github.com/github/codeql-action/releases/download/codeql-bundle-v2.22.2/codeql-bundle-linux64.tar.zst .
    Downloading CodeQL tools from https://github.com/github/codeql-action/releases/download/codeql-bundle-v2.22.2/codeql-bundle-linux64.tar.zst . This may take a while.
    Streaming the extraction of the CodeQL bundle.
    node:events:502
          throw er; // Unhandled 'error' event
          ^

    Error: connect ECONNREFUSED 54.185.253.63:443
        at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1611:16)
    [...]
      errno: -111,
      code: 'ECONNREFUSED',
      syscall: 'connect',
      address: '54.185.253.63',
      port: 443
    }

    Node.js v20.19.3
    Post job cleanup.
    [...]

Allow `release-assets.githubusercontent.com:443`, which is what the
download link above resolves to.

[1] https://github.com/netblue30/firejail/actions/runs/16638865345/job/47085091964
kmk3 added a commit that referenced this pull request Jul 31, 2025
The `codeql-cpp` CI job for #6844 is failing[1]:

    ##[group]Setup CodeQL tools
    [...]
    Did not find CodeQL tools version 2.22.2 in the toolcache.
    Using CodeQL CLI version 2.22.2 sourced from https://github.com/github/codeql-action/releases/download/codeql-bundle-v2.22.2/codeql-bundle-linux64.tar.zst .
    Downloading CodeQL tools from https://github.com/github/codeql-action/releases/download/codeql-bundle-v2.22.2/codeql-bundle-linux64.tar.zst . This may take a while.
    Streaming the extraction of the CodeQL bundle.
    node:events:502
          throw er; // Unhandled 'error' event
          ^

    Error: connect ECONNREFUSED 54.185.253.63:443
        at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1611:16)
    [...]
      errno: -111,
      code: 'ECONNREFUSED',
      syscall: 'connect',
      address: '54.185.253.63',
      port: 443
    }

    Node.js v20.19.3
    Post job cleanup.
    [...]

Allow `release-assets.githubusercontent.com:443`, which is what the
download link above resolves to.

[1] https://github.com/netblue30/firejail/actions/runs/16638865345/job/47085091964
This reverts commit d54f798 ("bugfix: fcopy: add /usr/share +
"runner:root" exception to fix CI (netblue30#6803)", 2025-07-07).

After reporting the issue to GitHub, the CI test jobs are now working
even for 0.9.74[1] and it seems that /usr/share and /opt are owned by
`root:root` again[2] [3]:

    drwxrwxrwx+ 214 root root 4096 Jul 20 22:00 /usr/share
    drwxrwxrwx+  14 root root 4096 Jul 20 23:01 /opt

This is apparently resolved as of the ubuntu-22.04 image version
20250720.1[3] [4] [5].

Relates to netblue30#1531 netblue30#6797.

[1] https://github.com/netblue30/firejail/actions/runs/16638617665
[2] actions/runner-images#12526
[3] actions/runner-images#12526 (comment)
[4] https://github.com/actions/runner-images/blob/ubuntu22/20250720.1/images/ubuntu/Ubuntu2204-Readme.md
[5] https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20250720.1
@kmk3 kmk3 force-pushed the fcopy-rm-ci-workaround branch from 889d873 to cb830d0 Compare July 31, 2025 05:23
@kmk3 kmk3 moved this to Todo in Release 0.9.78 Jul 31, 2025
@kmk3 kmk3 merged commit 6068956 into netblue30:master Aug 1, 2025
12 checks passed
@kmk3 kmk3 deleted the fcopy-rm-ci-workaround branch August 1, 2025 04:18
@github-project-automation github-project-automation bot moved this from Todo to Done in Release 0.9.78 Aug 1, 2025
kmk3 added a commit that referenced this pull request Aug 5, 2025
@kmk3 kmk3 moved this from Done to Done (on RELNOTES) in Release 0.9.78 Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant