Skip to content

Add tx_index to TxStatus for get_transaction RPC #4583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2024
Merged

Add tx_index to TxStatus for get_transaction RPC #4583

merged 2 commits into from
Aug 13, 2024

Conversation

eval-exec
Copy link
Collaborator

What problem does this PR solve?

Related changes

  • Add tx_index for TxStatus for get_transaction RPC

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec force-pushed the exec/get_transaction_index branch 4 times, most recently from 0fcf9a8 to 9380b9a Compare August 13, 2024 05:29
@eval-exec eval-exec requested a review from quake August 13, 2024 05:30
@eval-exec eval-exec marked this pull request as ready for review August 13, 2024 05:30
@eval-exec eval-exec requested a review from a team as a code owner August 13, 2024 05:30
@eval-exec eval-exec changed the title Add tx_index to TxStatus for get_transaction RPC Add tx_index to TxStatus for get_transaction RPC Aug 13, 2024
@eval-exec eval-exec added the b:rpc Break RPC interface label Aug 13, 2024
@chenyukang chenyukang added this pull request to the merge queue Aug 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2024
@eval-exec
Copy link
Collaborator Author

wait #4584

@eval-exec eval-exec added this pull request to the merge queue Aug 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2024
@eval-exec eval-exec force-pushed the exec/get_transaction_index branch from 9f33daa to 0d18f5b Compare August 13, 2024 13:20
@eval-exec eval-exec enabled auto-merge August 13, 2024 13:21
@eval-exec eval-exec added this pull request to the merge queue Aug 13, 2024
Merged via the queue into nervosnetwork:develop with commit c35415f Aug 13, 2024
This was referenced Aug 14, 2024
Closed
Closed
Merged
Merged
@doitian doitian mentioned this pull request Aug 19, 2024
Closed
3 tasks
@15168316096 15168316096 mentioned this pull request Aug 19, 2024
Open
3 tasks
@15168316096 15168316096 mentioned this pull request Aug 28, 2024
Merged
4 tasks
@contrun contrun mentioned this pull request Oct 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quake quake quake approved these changes

Assignees

No one assigned

Labels

b:rpc Break RPC interface

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eval-exec @quake