Update the signature of the load cell code #140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxuejie
reviewed
Aug 13, 2025
| let result = get().load_cell_code(buf_ptr, len, content_offset, content_size, index, source); | ||
| match result { | ||
| Ok(()) => Ok(len), | ||
| Ok(_) => Ok(len), |
There was a problem hiding this comment.
With this style of API, you should iterate based on the result of load_cell_code, and then fill in the actual data for each MemoryPageResult structure.
|
Due to design changes, this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
load_cell_codeto return a list of MemoryPageResult, indicating which memory pages it should or has modified.Ref nervosnetwork/ckb-vm-contrib#22 (comment)