fix: type annotations #4010
Merged
fix: type annotations #4010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
changed the title
|
Nice, this found some actual bugs. Thanks! |
justinmk
reviewed
Aug 19, 2025
| @@ -8,6 +8,7 @@ | |||
| --- | |||
| --- * Initialization: https://github.com/muffinmad/anakin-language-server#initialization-option | |||
| --- * Configuration: https://github.com/muffinmad/anakin-language-server#configuration-options | |||
| ---@type vim.lsp.Config | |||
There was a problem hiding this comment.
Need a blank line above this. Else the ---@type... is part of the generated doc. Plus that's more "correct" anyway since a @brief doc describes the module, not any particular code in the module.
There was a problem hiding this comment.
Oopsie! I swear, this must be a curse: every small contribution I make here comes with a subtle bug 😭
Follow-up: #4017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
---@type vim.lsp.Configfor configs and fixes some type related issues (and some minor inconsistencies).To make it easier for review, it's split into 2 commits.
TODO: add lint rule