Skip to content

fix(nushell): avoid nil root_dir (reapply #3611) #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

fix(nushell): avoid nil root_dir (reapply #3611) #3861

merged 2 commits into from
May 23, 2025

Conversation

Bahex
Copy link
Contributor

@Bahex Bahex commented May 21, 2025 •
edited by justinmk
Loading

Simplified lsp/nushell.lua unfortunately triggered the problem with the lsp server again.

From #3611 :

nushell 0.102 made some changes that a nil root_dir will cause lsp server to exit.

justinmk
justinmk reviewed May 22, 2025
View reviewed changes
@justinmk
Copy link
Member

In the future please give a clear explanation. I updated your description.

@justinmk justinmk merged commit 8d798d5 into neovim:master May 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmk justinmk justinmk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bahex @justinmk