fix: ":checkhealth lspconfig" fails on Nvim 0.11 #3668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk
force-pushed
the
fixcheckhealth
branch
from
a4ce4fd to
e6c28bb
Compare
Problem:
`:checkhealth lspconfig` fails:
E5009: Invalid $VIMRUNTIME: .../share/nvim/runtime
Error executing lua: Vim:E21: Cannot make changes, 'modifiable' is off
stack traceback:
[C]: in function 'append'
.../share/nvim/runtime/lua/vim/health.lua:443: in function '_check'
`:checkhealth` cannot call itself recursively. And even if it did work,
it would show a duplicate report since `:checkhealth vim.lsp` will also
be part of the report.
Solution:
On Nvim 0.11,
- show a deprecation message if invoked directly.
- show a softer message if invoked as part of the "full report".
fix #3664
justinmk
force-pushed
the
fixcheckhealth
branch
from
e6c28bb to
36b5245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
:checkhealth lspconfigfails::checkhealthcannot call itself recursively. And even if it did work, it would show a duplicate report since:checkhealth vim.lspwill also be part of the report.Solution:
On Nvim 0.11,
fix #3664