Skip to content

Conversation

@Sebobo
Copy link
Member

@Sebobo Sebobo commented Oct 10, 2025

No description provided.

@mhsdesign
Copy link
Member

mhsdesign commented Oct 10, 2025

Thx and we should also enable php 8.3 in the ci then

edit: we have ci for php 8.4 but apparently without use 😅

@Sebobo
Copy link
Member Author

Sebobo commented Oct 10, 2025

There is probably more. Will check next week thoroughly.

@Sebobo Sebobo force-pushed the bugfix/resolve-deprecation-warnings branch from beb9112 to 3a4568f Compare October 14, 2025 07:34
@Sebobo Sebobo marked this pull request as ready for review October 14, 2025 07:37
@Sebobo Sebobo requested a review from mhsdesign October 14, 2025 09:04
@Sebobo Sebobo moved this to Review Required 👀 in Neos 8.4 Release Board Oct 16, 2025
@Sebobo Sebobo requested a review from dlubitz October 17, 2025 07:41
@dlubitz
Copy link
Contributor

dlubitz commented Oct 17, 2025

You can use phprector for this, that works very well.
https://getrector.com/rule-detail/explicit-nullable-param-type-rector

@dlubitz
Copy link
Contributor

dlubitz commented Oct 17, 2025

See: #5442

Copy link
Member

@skurfuerst skurfuerst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good by reading ❤️

@Sebobo Sebobo merged commit 80cf711 into 8.4 Oct 23, 2025
9 checks passed
@Sebobo Sebobo deleted the bugfix/resolve-deprecation-warnings branch October 23, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Review Required 👀

Development

Successfully merging this pull request may close these issues.

4 participants