TASK: Remove obsolete affected source dsp from node aggregate was removed

[mhsdesign]

Remove possibly incorrect or undefined NodeAggregateWasRemoved::$affectedOccupiedDimensionSpacePoints

Originally 8bccb95 introduced $affectedOccupiedDimensionSpacePoints for the change projection

Now with soft removals we dont need to focus on NodeAggregateWasRemoved and could even ignore them. There is no need to difference between occupied and covered as soft removals cant do this either (#5507).
This change thus marks removal events in all affectedCoveredDimensionSpacePoints instead. They will not be shown in the workspace module either way and its more of a debug tool.

Previously removeNodeInDimensionSpacePointSet issued not necessarily occupied points and also when removing a root node aggregate it might be surprising to find out that $affectedOccupiedDimensionSpacePoints is empty because the root node doesnt occupy a special point.

To simplify the discussion for now we remove this now unused feature

Well have to revise the question for affected vs source dimension space points either way in a professional manner for other events, see #4265 (comment) but that is not for now.

Upgrade instructions

Review instructions

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[mhsdesign]

This is required for the fix of UpdateRootNodeAggregateDimensions in #5514 which removes the root node aggregate in dedicated dimensions.

At the current state of implementation i have to lie about the affected source:

neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/RootNodeCreation/RootNodeHandling.php

Lines 184 to 185 in 400d559

	// TODO root nodes never occupy, but this field is odd, unused and to be removed either way: https://github.com/neos/neos-development-collection/pull/5516
	affectedOccupiedDimensionSpacePoints: OriginDimensionSpacePointSet::fromArray([]),

neos-development-collection/Neos.ContentRepository.BehavioralTests/Tests/Behavior/Features/RootNodeAggregateDimensionUpdates/UpdateRootNodeAggregateDimensions_WithDimensions.feature

Lines 502 to 504 in 400d559

	# todo remove this field, its wrong: https://github.com/neos/neos-development-collection/pull/5516
	| affectedOccupiedDimensionSpacePoints | [] |
	| affectedCoveredDimensionSpacePoints | [{"language":"de"},{"language":"gsw"}] |

We previously never ran into that problem because RemoveNodeAggregate did not allow to remove a root node in only a certain dimensions.

neos-development-collection/Neos.ContentRepository.Core/Classes/Feature/NodeRemoval/NodeRemoval.php

Lines 57 to 59 in c98608b

	if ($nodeAggregate->classification->isRoot() && $command->nodeVariantSelectionStrategy !== NodeVariantSelectionStrategy::STRATEGY_ALL_VARIANTS) {
	throw new \RuntimeException(sprintf('Root node aggregates can only be removed by using node variant selection strategy "%s"', NodeVariantSelectionStrategy::STRATEGY_ALL_VARIANTS->value), 1740753598);
	}

But as we write removal events in UpdateRootNodeAggregateDimensions we do now care.

[nezaniel]

Since the affected occupied DSPs are always a subset of the affected covered ones and projections et al must keep track of origins themselves anyway (if they care for them at all), we can (and should) safely remove this.