TASK: Upmerges #4170
Merged
TASK: Upmerges #4170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starting with PHP 7.4 it's not cool to do offset access on integers (which returns null always) I did a little digging, and we have this skip keys logic 3 times in the runtime (probably not extracted for performance reasons) 2 times this logic needs to be adjusted to only operate on strings. Those two snippets where introduced with #2738 And 1 time this logic already has an is_string check. https://github.com/neos/neos-development-collection/blob/046e5d02750af0ebf33cc52663799ce09683ba37/Neos.Fusion/Classes/Core/Runtime.php#L667 This was adjusted when 7.4 compatibility was introduced via #2804 but the other two references where not adjusted
Add NPM configuration and enable just security fixes.
strongly inspired by this pattern:
```
root = Neos.Fusion:Component {
text = "foo"
[email protected] = Neos.Fusion:DataStructure {
foo = ${props.text + "!"}
}
renderer = ${props.text + private.foo}
}
```
I present to you the pattern of @computed props:
```
root = Neos.Fusion:Component {
text = "foo"
@computed {
foo = ${props.text + "!"}
}
renderer = ${props.text + computed.foo}
}
```
…e looped or applied
partly reverts 61f2c47
…via FusionCodeCollection
…Parser::parseFrom` `Parser::parse` is @deprecated
…Invalid with factory methods
if (trim($sourceCode) === '') throw Error We cant do that, as its currently allowed to have an empty Root.fusion https://github.com/neos/neos-development-collection/pull/3839/files#r1002435846
The goal was not to violate our @api guideline so no public @api methods are changed. The FusionService is now partly deprecated. Fixes #3985
Currently translated at 100.0% (322 of 322 strings) Co-authored-by: Anonymous <[email protected]> Translate-URL: https://hosted.weblate.org/projects/neos/neos-neos-modules-82/nl/ Translation: Neos/Neos.Neos - Modules - 8.2
This is expected to fail in cases where count is not implemented.
…`Neos.Fusion:Loop` and `Neos.Fusion:Reduce` This leads to `isLast` never beeing true which is fair if we cannot count the items.
…rate-command FEATURE: Introduce node:migrationcreate command
…terablesThatDoNotImplementCount FEATURE: Support `iterables` that do not implement `countable` in `Neos.Fusion:Map`, `Neos.Fusion:Loop` and `Neos.Fusion:Reduce`
bwaidelich
commented
Apr 5, 2023
…nService #4089 - remove the setting "Neos.EventSourcedNeosAdjustments.fusion.enableObjectTreeCache", we use Neos.Neos as namespace as in 8.3 - set enableObjectTreeCache to true and solve todo of enableObjectTreeCache > TODO: re-enable cache!!! and (really outdated since context was not used anymore since nov 2020 in the neos.neos aspect) > we need to disable the fusion object tree cache by now because it relies on the context; we replace it with our own FusionCachingAspect.
|
I did now upmerge the FusionService and friends of #3839 correctly.
also the FusionCachingAspect was not really up to date as it seems in the 9.0 branch and dindt use this fix #3191 edit: locally untested - and the ci is sleeping? |
will be handled separately in #4089 otherwise this is not cool to handle in a merge commit
...and disable functional tests (for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.