9.0 FEATURE: Migrate content dimensions in a running installation #4093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required when changing dimension values in a running installation
skurfuerst
commented
Mar 15, 2023
| @@ -405,6 +408,8 @@ protected function adoptNodeAndParents( | |||
| throw new \RuntimeException('Source node for Node Aggregate ID ' . $identifier | |||
| . ' not found. This should never happen.', 1660905374); | |||
| } | |||
| var_dump("SOURCENODE"); | |||
| var_dump($sourceNode->nodeAggregateId); | |||
There was a problem hiding this comment.
remove (all occurences in this class
| @@ -57,6 +58,9 @@ private function handleCreateNodeVariant( | |||
| $command->nodeAggregateId, | |||
| $contentRepository | |||
| ); | |||
| if ($nodeAggregate->classification->isRoot()) { | |||
There was a problem hiding this comment.
TODO: this seems to be already checked. so remove exception below.
| */ | ||
| public function first(): NodeAggregate | ||
| { | ||
| if (count($this->nodeAggregates) > 0) { |
There was a problem hiding this comment.
TODO: move exception check to findRootNodeAggregateByType; and return nullable NodeAggregate (for internal consistency)
| @@ -46,13 +46,22 @@ public function getSubgraph( | |||
| ): ContentSubgraphInterface; | |||
|
|
|||
| /** | |||
| * @api | |||
| * @deprecated please use {@see findRootNodeAggregates} instead | |||
| * @internal | |||
skurfuerst
added a commit
that referenced
this pull request
Mar 17, 2023
I forgot to change this after discussing in #4093 so this is the cleanup commit.
neos-bot
pushed a commit
to neos/contentgraph-doctrinedbaladapter
that referenced
this pull request
May 1, 2023
I forgot to change this after discussing in neos/neos-development-collection#4093 so this is the cleanup commit.
neos-bot
pushed a commit
to neos/contentgraph-postgresqladapter
that referenced
this pull request
May 1, 2023
I forgot to change this after discussing in neos/neos-development-collection#4093 so this is the cleanup commit.
neos-bot
pushed a commit
to neos/contentrepository-core
that referenced
this pull request
May 1, 2023
I forgot to change this after discussing in neos/neos-development-collection#4093 so this is the cleanup commit.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: