Skip to content

Conversation

bwaidelich
Copy link
Member

@bwaidelich bwaidelich commented Mar 7, 2023

  • Add behat tests for all Subgraph API methods
  • Extract runtime caches from \Neos\ContentGraph\DoctrineDbalAdapter\Domain\Repository\ContentSubgraph to a new adapter implementation Neos\ContentRepository\Core\Projection\ContentGraph\ContentGraphWithRuntimeCaches
  • Replace custom SqlQueryBuilder by the Doctrine DBAL QueryBuilder
  • Unify behavior of Subgraph filters and methods (preparation for !!! FEATURE: Cleanup Subgraph API #4090)
  • Fix edge cases in ContentSubgraph and ContentSubhypergraph

Related: #4075

1/x add behat tests for the `ContentSubgraphInterface` implementations,
fix easy bugs and tweak filters and return types slightly

Related: #4075
@bwaidelich bwaidelich changed the title FEATURE: Stabilize & extend Content Subgraph API FEATURE: Stabilize Content Subgraph API Mar 9, 2023
@bwaidelich bwaidelich marked this pull request as ready for review March 9, 2023 20:51
@bwaidelich
Copy link
Member Author

NOTE: Based on #4079

@bwaidelich
Copy link
Member Author

I just found out that the new ContentSubgraphWithRuntimeCaches is still buggy. I'll add some tests and fix it!

@bwaidelich bwaidelich merged commit 8856517 into 9.0 Mar 10, 2023
@bwaidelich bwaidelich deleted the feature/4075-stabilize-subgraph-api branch March 10, 2023 17:06
bwaidelich added a commit that referenced this pull request Nov 23, 2023
With #4076 the `ContentSubgraph` was adjusted to use the Doctrine DBAL
QueryBuilder.
This change adjusts the `ContentGraph` implementation accordingly
bwaidelich added a commit that referenced this pull request Nov 29, 2023
With #4076 the `ContentSubgraph` was adjusted to use the Doctrine DBAL
QueryBuilder.
This change adjusts the `ContentGraph` implementation accordingly

# Conflicts:
#	Neos.ContentGraph.DoctrineDbalAdapter/src/Domain/Repository/ContentGraph.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants