9.0 !!! REFACTOR: adjust move event structure (breaking event payload change) #3913
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToDo List
The current structure of the NodeAggregateWasMoved is rather complex. Especially the
NodeMoveMappings
are hard to grasp.Besides, the hash of the affected ContentDimensionSpacepoints is expected as keys for
NodeVariantAssignments::createFromArray()
which makes this error prone. Also it makes the internal implementation detail part of the event payload.Solution
It makes sense to combine the two sets
newParentAssignments
andnewSucceedingSiblingAssignments
into one and to replace the associative array, e.g.:OLD:
New:
Resolves: #3825